Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back RequestInit.priority property #1572

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

SevenOutman
Copy link
Contributor

Fix microsoft/TypeScript#54472

As of today (2023-06), RequestInit.priority (MDN) already has considerable range of support according to caniuse.com

image

Additional Info

The generated RequestInit.priority doesn't have a descriptive comment. I found that comments for other RequestInit members are located in inputfiles/idl/fetch.commentmap.json, the README informs that this file should be updated with npm run fetch but this script seems missing now. How could I add the comments?

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@SevenOutman
Copy link
Contributor Author

@microsoft-github-policy-service agree

@HolgerJeromin
Copy link
Contributor

As of today (2023-06), RequestInit.priority (MDN) already has considerable range of support according to caniuse.com

No. This is all one engine (blink).

https://github.com/microsoft/TypeScript-DOM-lib-generator#when-the-type-is-missing

Copy link

@max-carroll-sky max-carroll-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davecardwell
Copy link

davecardwell commented Dec 1, 2023

Could this be reconsidered for merging please?

cc/ @saschanaz @HolgerJeromin

@HolgerJeromin
Copy link
Contributor

Firefox have it ticketed as part of their Fetch Priority work

I know (for me) important firefox tickets which are 10+ years old :-)
I am pretty sure this will be merged when Safari or Firefox get this stable.

@HolgerJeromin
Copy link
Contributor

#1654 added fetchprio for image because of
mdn/browser-compat-data#21267
Perhaps we should merge this very pr now.

@saschanaz
Copy link
Contributor

I filed mdn/browser-compat-data#21421 as I can confirm that Safari 17.2 has this. LGTM.

Copy link
Contributor

github-actions bot commented Dec 2, 2023

Sorry @saschanaz, this PR has merge conflicts. They'll need to be fixed before this can be merged.

@saschanaz
Copy link
Contributor

(But this PR has conflict)

@SevenOutman
Copy link
Contributor Author

(But this PR has conflict)

I'll have them resolved this week.

@SevenOutman
Copy link
Contributor Author

SevenOutman commented Dec 10, 2023

@saschanaz Conflicts resolved.

@saschanaz
Copy link
Contributor

Lgtm

@github-actions github-actions bot merged commit de32b7c into microsoft:main Dec 10, 2023
5 checks passed
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

@SevenOutman SevenOutman deleted the add-RequestInit-priority branch December 12, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestInit.priority type
5 participants