-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back RequestInit.priority property #1572
Add back RequestInit.priority property #1572
Conversation
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
@microsoft-github-policy-service agree |
No. This is all one engine (blink). https://github.com/microsoft/TypeScript-DOM-lib-generator#when-the-type-is-missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could this be reconsidered for merging please?
|
I know (for me) important firefox tickets which are 10+ years old :-) |
#1654 added fetchprio for image because of |
I filed mdn/browser-compat-data#21421 as I can confirm that Safari 17.2 has this. LGTM. |
Sorry @saschanaz, this PR has merge conflicts. They'll need to be fixed before this can be merged. |
(But this PR has conflict) |
I'll have them resolved this week. |
967b50c
to
ca10ff4
Compare
@saschanaz Conflicts resolved. |
Lgtm |
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Fix microsoft/TypeScript#54472
As of today (2023-06),
RequestInit.priority
(MDN) already has considerable range of support according to caniuse.comAdditional Info
The generated
RequestInit.priority
doesn't have a descriptive comment. I found that comments for otherRequestInit
members are located ininputfiles/idl/fetch.commentmap.json
, the README informs that this file should be updated withnpm run fetch
but this script seems missing now. How could I add the comments?