Improve method signatures returning Node type #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
suggested changes
Mar 27, 2017
baselines/dom.generated.d.ts
Outdated
| @@ -8249,20 +8249,20 @@ interface Node extends EventTarget { | |||
| readonly previousSibling: Node | null; | |||
| textContent: string | null; | |||
| appendChild<T extends Node>(newChild: T): T; | |||
| cloneNode(deep?: boolean): Node; | |||
| cloneNode(deep?: boolean): this; | |||
There was a problem hiding this comment.
This will make all the Node hierarchy generic, something we have avoided for perf reasons. see #166 for more details.
The alternative here is for every interface that extends from Node, we can redefine cloneNode to return the containing type.
There was a problem hiding this comment.
The other alternative is to just leave cloneNode the way it is and take the other changes.
There was a problem hiding this comment.
Agreed, I expected this fix to work as an easy workaround. Done.
|
thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/TypeScript#14863