Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeParent property to HTML, Document and DocumentFragment #66

Closed
wants to merge 12 commits into from
Closed

Add nodeParent property to HTML, Document and DocumentFragment #66

wants to merge 12 commits into from

Conversation

YuichiNukiyama
Copy link
Contributor

Add parentNode property to Element, Document and DocumentFragment.
spec: ParentNode
original issue: ParentNode interface isn't implemented in lib.d.ts #4400

delete extra space.
Add childElementCount property.
@YuichiNukiyama
Copy link
Contributor Author

In the Living standard, parentNode property of the Node interface return a Node. However, it not implemented because of abstract interface. In order to eliminate the error, should I change the parentNode of the return type?
4.4. Interface Node

@@ -12659,6 +12662,13 @@ declare var HTMLPictureElement: {
new(): HTMLPictureElement;
}

interface parentNode {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Camel Case. so ParentNode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did it.

@mhegazy
Copy link
Contributor

mhegazy commented Feb 17, 2016

parentNode: Node seems fine to me,

change interface name. and remove parentNode property from
DocumentFragment interface.
]
},
{
"kind": "property",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not think this should be a property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this interface, too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be added to the extends list. i do not know how to do that though :) @zhengbli what is the right way to do this?

@mhegazy
Copy link
Contributor

mhegazy commented Mar 15, 2016

@zhengbli any ideas?

@zhengbli zhengbli mentioned this pull request Mar 21, 2016
@zhengbli
Copy link
Contributor

The support for adding extends is being added at #79 , once that merge in you can update the PR. Thanks!

@YuichiNukiyama
Copy link
Contributor Author

@zhengbli @mhegazy I update addType.json L404 to L438

@YuichiNukiyama
Copy link
Contributor Author

I missed operation. I close this PR and redo.

orta pushed a commit to orta/TSJS-lib-generator that referenced this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants