-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodeParent property to HTML, Document and DocumentFragment #66
Conversation
Add parentNode property to Element, Document and DocumentFragment. spec; [ParentNode](https://developer.mozilla.org/en-US/docs/Web/API/ParentNode)
delete extra space.
Add childElementCount property.
In the Living standard, parentNode property of the Node interface return a Node. However, it not implemented because of abstract interface. In order to eliminate the error, should I change the parentNode of the return type? |
@@ -12659,6 +12662,13 @@ declare var HTMLPictureElement: { | |||
new(): HTMLPictureElement; | |||
} | |||
|
|||
interface parentNode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use Camel Case. so ParentNode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did it.
|
] | ||
}, | ||
{ | ||
"kind": "property", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do not think this should be a property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this interface, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be added to the extends list. i do not know how to do that though :) @zhengbli what is the right way to do this?
@zhengbli any ideas? |
The support for adding |
Merge remote-tracking branch 'tsjsupstream/master'
I missed operation. I close this PR and redo. |
Add parentNode property to Element, Document and DocumentFragment.
spec: ParentNode
original issue: ParentNode interface isn't implemented in lib.d.ts #4400