Skip to content

Commit

Permalink
Merge pull request #3 from microsoft/fix_nightly
Browse files Browse the repository at this point in the history
Fix nightlies and adds some docs
  • Loading branch information
Orta Therox authored Oct 26, 2020
2 parents 1898c51 + 9d836d8 commit c581abd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
9 changes: 8 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,14 @@ Delete the local tag, re-create it, and force push it up:

> `git tag -d 3.8.2 && git tag 3.8.2 && git push origin 3.8.2 -f`
Note that npm won't allow re-publishing the same version, so you better do it quick if you need to edit it.
Note that npm won't allow re-publishing the same version, so you better do it quick if you need to edit it. The playground doesn't use the npm versions however, so they will get updated.

### Troubleshooting

Are you here because of a failing build? Chances are your issue comes up from a `require` statement inside the TypeScript codebase.
The logs will let you know if this is the issue.

This has happened a few times, you need to go to [microsoft/monaco-typescript](https://github.com/microsoft/monaco-typescript) and look at [`./scripts/importTypeScript.js`](https://github.com/microsoft/monaco-typescript/blob/master/scripts/importTypescript.js). Fix it there (I update the TS version in that repo, then fix the script, and send a PR for just that script change: e.g. [#72](https://github.com/microsoft/monaco-typescript/pull/72)) then come back to the file in this repo: [`./publish-monaco-ts.js`](https://github.com/orta/make-monaco-builds/blob/master/publish-monaco-ts.js) and add a step to merge in your new PR e.g. [#3](https://github.com/microsoft/TypeScript-Make-Monaco-Builds/pull/3).

# Contributing

Expand Down
2 changes: 1 addition & 1 deletion publish-monaco-ts.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function main() {
execMTS(`git config --global user.email "you@example.com"`)
execMTS(`git config --global user.name "Your Name"`)

failableMergeBranch(execMTS, "ts_4_1_b")
failableMergeBranch(execMTS, "41_perf_require")

step("Installing NPM");
execMTS("npm i")
Expand Down

0 comments on commit c581abd

Please sign in to comment.