Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment containing } in function Declaration Breaks Highlighting #455

Closed
mjbvz opened this issue May 16, 2017 · 0 comments
Closed

Comment containing } in function Declaration Breaks Highlighting #455

mjbvz opened this issue May 16, 2017 · 0 comments

Comments

@mjbvz
Copy link
Contributor

mjbvz commented May 16, 2017

TS and JS Grammar Extension version: 0.0.19 / latest

From: microsoft/vscode#26221

Code

func(function () // }
{
    if (false)
        return 1
    else
        return 2
});

screen shot 2017-05-15 at 5 09 17 pm

It seems the } in the commend causes the function scoped to be closed early
@mjbvz mjbvz mentioned this issue May 16, 2017
Closed
sheetalkamat added a commit that referenced this issue Aug 21, 2018
@sheetalkamat
Handle function expressions to consume line ending of single line com…
ebb42d0 
…ment since we rely on lookback of function completion (})

Fixes #455 after making change in comments to not consume line endings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjbvz