Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: add zh translation of "Nightly Builds" #1458

Merged
merged 1 commit into from
Jan 21, 2021
Merged

i18n: add zh translation of "Nightly Builds" #1458

merged 1 commit into from
Jan 21, 2021

Conversation

zhongsp
Copy link
Contributor

@zhongsp zhongsp commented Jan 3, 2021

Translate packages\documentation\copy\en\Nightly Builds.md into Simplified Chinese.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2021

Thanks for the PR!

This section of the codebase is owned by @Kingwl - if they write a comment saying "LGTM" then it will be merged.

@zhongsp
Copy link
Contributor Author

zhongsp commented Jan 3, 2021

@Kingwl , my first commit to this repo. Could you please help to review it? Thanks.

@Kingwl
Copy link
Contributor

Kingwl commented Jan 4, 2021

Sure.

@Kingwl
Copy link
Contributor

Kingwl commented Jan 4, 2021

A little problem. Others look good.

translatable: true
---

在太平洋标准时间的每日午夜,TypeScript 代码仓库中[master 分支](https://github.com/Microsoft/TypeScript/tree/master)上的代码会自动构建并发布到 npm 上。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: It's better to add UTC+8 time

(16:00 UTC+8)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay never mind

@Kingwl
Copy link
Contributor

Kingwl commented Jan 21, 2021

LGTM

@github-actions github-actions bot merged commit 0139141 into microsoft:v2 Jan 21, 2021
@github-actions
Copy link
Contributor

Merging because @Kingwl is a code-owner of all the changes - thanks!

@Kingwl
Copy link
Contributor

Kingwl commented Jan 21, 2021

Thanks!

@zhongsp zhongsp deleted the zhongsp/zh-doc-nightly-builds branch January 27, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants