Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sample for incremental compiling and solution builder #225

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add sample for incremental compiling and solution builder #225

wants to merge 3 commits into from

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Sep 3, 2019 •
edited
Loading

@johnnyreilly johnnyreilly mentioned this pull request Sep 4, 2019
Closed
@sheetalkamat sheetalkamat changed the title Add sample for incremental compiling Add sample for incremental compiling and solution builder Sep 4, 2019
ulrichb
ulrichb reviewed Sep 10, 2019
View reviewed changes
Using-the-Compiler-API.md
...program.getOptionsDiagnostics(),
...program.getGlobalDiagnostics(),
...program.getSemanticDiagnostics() // Get the diagnostics before emit to cache them in the buildInfo file.
];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We not ts.getPreEmitDiagnostics() instead of duplicating the get___Diagnostics() calls?

What about ts.sortAndDeduplicateDiagnostics(diagnostics)?

gbalint
gbalint reviewed Nov 7, 2019
View reviewed changes
Using-the-Compiler-API.md
}

const program = ts.createIncrementalProgram({
rootName: config.fileNames,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: this is rootNames and not rootName

gbalint
gbalint reviewed Nov 7, 2019
View reviewed changes
Using-the-Compiler-API.md
/*optionsToExtend*/ { incremental: true },
/*host*/ {
...ts.sys,
onUnRecoverableConfigFileDiagnostic: d => console.error(ts.flattenDiagnosticMessageText(d, "\n"));
Copy link

@gbalint gbalint Nov 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be:

onUnRecoverableConfigFileDiagnostic: d => console.error(ts.flattenDiagnosticMessageText(d.messageText, "\n"));

Now it throws a compile error:

Argument of type 'Diagnostic' is not assignable to parameter of type 'string | DiagnosticMessageChain | undefined'.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an invalid semi colon at the end

onUnRecoverableConfigFileDiagnostic: d => console.error(ts.flattenDiagnosticMessageText(d.messageText, "\n"));

@orta orta force-pushed the master branch 5 times, most recently from c888fbb to 9927788 Compare November 12, 2019 17:20
@orta orta force-pushed the master branch 3 times, most recently from 5c070ad to fbcbe2a Compare December 16, 2019 16:56
@ahnpnl
Copy link

ahnpnl commented Feb 17, 2020

hi @sheetalkamat , is it possible to have an example of using createIncrementalCompilerHost ? I'm looking at your example in this PR, createIncrementalCompilerHost is mentioned but there is no example usage.

@cspotcode cspotcode mentioned this pull request Feb 18, 2020
Closed
@cspotcode
Copy link

This PR refers to IncrementalCompilerHost, but I can't find where that type is declared. I see that createIncrementalCompilerHost returns a normal CompilerHost.

If possible, it would be great to have an explanation of getSourceFile's argument shouldCreateNewSourceFile. I'm trying to implement an efficient CompilerHost and I'm not sure if I'm allowed to return the same SourceFile instance multiple times from my getSourceFile implementation.

@tamj0rd2 tamj0rd2 mentioned this pull request Jul 21, 2020
Closed
HexMox
HexMox reviewed Aug 28, 2020
View reviewed changes
Using-the-Compiler-API.md
);

// Builds the solution and watches for changes
solution.clean();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be: solution.build()

@perbergland perbergland mentioned this pull request Oct 19, 2020
Open
@perbergland
Copy link

This PR is a goldmine - would be great to see it merged now one year after its creation

@JasonKleban JasonKleban mentioned this pull request Dec 24, 2020
Open
@JasonKleban
Copy link

@sheetalkamat is there something outdated about this API that is holding up this documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HexMox HexMox HexMox left review comments

@hipstersmoothie hipstersmoothie hipstersmoothie left review comments

@ulrichb ulrichb ulrichb left review comments

@gbalint gbalint gbalint left review comments

@danielbodart danielbodart danielbodart left review comments

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@sheetalkamat sheetalkamat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document --incremental and composite project APIs