Disallow incremental with noEmit (#36483)

Fixes #32882
microsoft · Jan 28, 2020 · 0e9416c · 0e9416c
1 parent f91f762
commit 0e9416c
Show file tree

Hide file tree

Showing 9 changed files with 82 additions and 0 deletions.
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -2987,6 +2987,10 @@ namespace ts {
                 programDiagnostics.add(createCompilerDiagnostic(Diagnostics.Option_incremental_can_only_be_specified_using_tsconfig_emitting_to_single_file_or_when_option_tsBuildInfoFile_is_specified));
             }
 
+            if (options.noEmit && isIncrementalCompilation(options)) {
+                createDiagnosticForOptionName(Diagnostics.Option_0_cannot_be_specified_with_option_1, "noEmit", options.incremental ? "incremental" : "composite");
+            }
+
             verifyProjectReferences();
 
             // List of collected files is complete; validate exhautiveness if this is a project with a file list

diff --git a/tests/baselines/reference/noEmitAndComposite.errors.txt b/tests/baselines/reference/noEmitAndComposite.errors.txt
@@ -0,0 +1,19 @@
+/tsconfig.json(3,9): error TS5053: Option 'noEmit' cannot be specified with option 'composite'.
+/tsconfig.json(4,9): error TS5053: Option 'noEmit' cannot be specified with option 'composite'.
+
+
+==== /tsconfig.json (2 errors) ====
+    {
+        "compilerOptions": {
+            "noEmit": true,
+            ~~~~~~~~
+!!! error TS5053: Option 'noEmit' cannot be specified with option 'composite'.
+            "composite": true
+            ~~~~~~~~~~~
+!!! error TS5053: Option 'noEmit' cannot be specified with option 'composite'.
+        }
+    }
+
+==== /a.ts (0 errors) ====
+    const x = 10;
+
diff --git a/tests/baselines/reference/noEmitAndComposite.symbols b/tests/baselines/reference/noEmitAndComposite.symbols
@@ -0,0 +1,4 @@
+=== /a.ts ===
+const x = 10;
+>x : Symbol(x, Decl(a.ts, 0, 5))
+
diff --git a/tests/baselines/reference/noEmitAndComposite.types b/tests/baselines/reference/noEmitAndComposite.types
@@ -0,0 +1,5 @@
+=== /a.ts ===
+const x = 10;
+>x : 10
+>10 : 10
+
diff --git a/tests/baselines/reference/noEmitAndIncremental.errors.txt b/tests/baselines/reference/noEmitAndIncremental.errors.txt
@@ -0,0 +1,20 @@
+/tsconfig.json(3,9): error TS5053: Option 'noEmit' cannot be specified with option 'incremental'.
+/tsconfig.json(4,9): error TS5053: Option 'noEmit' cannot be specified with option 'incremental'.
+
+
+==== /tsconfig.json (2 errors) ====
+    {
+        "compilerOptions": {
+            "noEmit": true,
+            ~~~~~~~~
+!!! error TS5053: Option 'noEmit' cannot be specified with option 'incremental'.
+            "incremental": true
+            ~~~~~~~~~~~~~
+!!! error TS5053: Option 'noEmit' cannot be specified with option 'incremental'.
+        }
+    }
+
+
+==== /a.ts (0 errors) ====
+    const x = 10;
+
diff --git a/tests/baselines/reference/noEmitAndIncremental.symbols b/tests/baselines/reference/noEmitAndIncremental.symbols
@@ -0,0 +1,4 @@
+=== /a.ts ===
+const x = 10;
+>x : Symbol(x, Decl(a.ts, 0, 5))
+
diff --git a/tests/baselines/reference/noEmitAndIncremental.types b/tests/baselines/reference/noEmitAndIncremental.types
@@ -0,0 +1,5 @@
+=== /a.ts ===
+const x = 10;
+>x : 10
+>10 : 10
+
diff --git a/tests/cases/compiler/noEmitAndComposite.ts b/tests/cases/compiler/noEmitAndComposite.ts
@@ -0,0 +1,10 @@
+// @Filename: /a.ts
+const x = 10;
+
+// @Filename: /tsconfig.json
+{
+    "compilerOptions": {
+        "noEmit": true,
+        "composite": true
+    }
+}
diff --git a/tests/cases/compiler/noEmitAndIncremental.ts b/tests/cases/compiler/noEmitAndIncremental.ts
@@ -0,0 +1,11 @@
+// @Filename: /a.ts
+const x = 10;
+
+// @Filename: /tsconfig.json
+{
+    "compilerOptions": {
+        "noEmit": true,
+        "incremental": true
+    }
+}
+