Merge remote-tracking branch 'origin/main' into release-5.6

microsoft · Aug 19, 2024 · 2a30c2a · 2a30c2a
2 parents b4732bd + 936a79b
commit 2a30c2a
Show file tree

Hide file tree

Showing 1,050 changed files with 79,092 additions and 23,484 deletions.
diff --git a/.c8rc.json b/.c8rc.json
@@ -1,5 +1,5 @@
 {
-    "reporter": ["lcovonly", "cobertura", "v8", "codecov"],
+    "reporter": ["lcovonly", "cobertura", "v8", "v8-json", "codecov"],
     "src": "src",
     "include": ["src/**", "built/local/**"],
     "exclude": ["**/node_modules/**"],

diff --git a/.dprint.jsonc b/.dprint.jsonc
@@ -59,8 +59,8 @@
     // Note: if adding new languages, make sure settings.template.json is updated too.
     // Also, if updating typescript, update the one in package.json.
     "plugins": [
-        "https://plugins.dprint.dev/typescript-0.91.4.wasm",
+        "https://plugins.dprint.dev/typescript-0.91.6.wasm",
         "https://plugins.dprint.dev/json-0.19.3.wasm",
-        "https://plugins.dprint.dev/prettier-0.40.0.json@68c668863ec834d4be0f6f5ccaab415df75336a992aceb7eeeb14fdf096a9e9c"
+        "https://plugins.dprint.dev/prettier-0.46.1.json@e5bd083088a8dfc6e5ce2d3c9bee81489b065bd5345ef55b59f5d96627928b7a"
     ]
 }
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -38,7 +38,6 @@ body:
 
         Please keep and fill in the line that best applies.
       value: |
-        - This is a crash
         - This changed between versions ______ and _______
         - This changed in commit or PR _______
         - This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -90,7 +90,7 @@ jobs:
         run: npm test -- --no-lint --coverage
 
       - name: Upload coverage artifact
-        uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4.3.4
+        uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
         with:
           name: coverage
           path: coverage
@@ -334,7 +334,7 @@ jobs:
 
       - name: Upload baseline diff artifact
         if: ${{ failure() && steps.check-baselines.conclusion == 'failure' }}
-        uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4.3.4
+        uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
         with:
           name: fix_baselines.patch
           path: fix_baselines.patch
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -46,7 +46,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@2d790406f505036ef40ecba973cc774a50395aac # v3.25.13
+        uses: github/codeql-action/init@429e1977040da7a23b6822b13c129cd1ba93dbb2 # v3.26.2
         with:
           config-file: ./.github/codeql/codeql-configuration.yml
         # Override language selection by uncommenting this and choosing your languages
@@ -56,7 +56,7 @@ jobs:
       # Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below).
       - name: Autobuild
-        uses: github/codeql-action/autobuild@2d790406f505036ef40ecba973cc774a50395aac # v3.25.13
+        uses: github/codeql-action/autobuild@429e1977040da7a23b6822b13c129cd1ba93dbb2 # v3.26.2
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -70,4 +70,4 @@ jobs:
       #     make release
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@2d790406f505036ef40ecba973cc774a50395aac # v3.25.13
+        uses: github/codeql-action/analyze@429e1977040da7a23b6822b13c129cd1ba93dbb2 # v3.26.2
diff --git a/.github/workflows/release-branch-artifact.yaml b/.github/workflows/release-branch-artifact.yaml
@@ -44,7 +44,7 @@ jobs:
           npm pack ./
           mv typescript-*.tgz typescript.tgz
       - name: Upload built tarfile
-        uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4.3.4
+        uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
         with:
           name: tgz
           path: typescript.tgz
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml
@@ -34,7 +34,7 @@ jobs:
           persist-credentials: false
 
       - name: 'Run analysis'
-        uses: ossf/scorecard-action@dc50aa9510b46c811795eb24b2f1ba02a914e534 # v2.3.3
+        uses: ossf/scorecard-action@62b2cac7ed8198b15735ed49ab1e5cf35480ba46 # v2.4.0
         with:
           results_file: results.sarif
           results_format: sarif
@@ -47,14 +47,14 @@ jobs:
       # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
       # format to the repository Actions tab.
       - name: 'Upload artifact'
-        uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4.3.4
+        uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
         with:
           name: SARIF file
           path: results.sarif
           retention-days: 5
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: 'Upload to code-scanning'
-        uses: github/codeql-action/upload-sarif@2d790406f505036ef40ecba973cc774a50395aac # v3.25.13
+        uses: github/codeql-action/upload-sarif@429e1977040da7a23b6822b13c129cd1ba93dbb2 # v3.26.2
         with:
           sarif_file: results.sarif
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -1,5 +1,6 @@
 // @ts-check
 import eslint from "@eslint/js";
+import * as regexpPlugin from "eslint-plugin-regexp";
 import fs from "fs";
 import globals from "globals";
 import { createRequire } from "module";
@@ -36,6 +37,7 @@ export default tseslint.config(
     eslint.configs.recommended,
     ...tseslint.configs.recommended,
     ...tseslint.configs.stylistic,
+    regexpPlugin.configs["flat/recommended"],
     {
         plugins: {
             local: {
@@ -123,24 +125,15 @@ export default tseslint.config(
             "@typescript-eslint/no-var-requires": "off",
             "@typescript-eslint/no-empty-interface": "off",
             "@typescript-eslint/no-explicit-any": "off",
-            "@typescript-eslint/ban-types": [
-                "error",
-                {
-                    extendDefaults: true,
-                    types: {
-                        // This is theoretically good, but ts-eslint appears to mistake our declaration of Symbol for the global Symbol type.
-                        // See: https://github.com/typescript-eslint/typescript-eslint/issues/7306
-                        "Symbol": false,
-                        "{}": false, // {} is a totally useful and valid type.
-                    },
-                },
-            ],
+            "@typescript-eslint/no-empty-object-type": "off", // {} is a totally useful and valid type.
+            "@typescript-eslint/no-require-imports": "off",
             "@typescript-eslint/no-unused-vars": [
                 "warn",
                 {
                     // Ignore: (solely underscores | starting with exactly one underscore)
                     argsIgnorePattern: "^(_+$|_[^_])",
                     varsIgnorePattern: "^(_+$|_[^_])",
+                    // Not setting an ignore pattern for caught errors; those can always be safely removed.
                 },
             ],
             "@typescript-eslint/no-inferrable-types": "off",
@@ -162,6 +155,7 @@ export default tseslint.config(
             "local/no-keywords": "error",
             "local/jsdoc-format": "error",
             "local/js-extensions": "error",
+            "local/no-array-mutating-method-expressions": "error",
         },
     },
     {
@@ -210,12 +204,21 @@ export default tseslint.config(
                 { name: "clearImmediate" },
                 { name: "performance" },
             ],
+            "local/no-direct-import": "error",
         },
     },
     {
         files: ["src/harness/**", "src/testRunner/**"],
         rules: {
             "no-restricted-globals": "off",
+            "regexp/no-super-linear-backtracking": "off",
+            "local/no-direct-import": "off",
+        },
+    },
+    {
+        files: ["src/**/_namespaces/**"],
+        rules: {
+            "local/no-direct-import": "off",
         },
     },
     {
@@ -231,7 +234,8 @@ export default tseslint.config(
             "@typescript-eslint/interface-name-prefix": "off",
             "@typescript-eslint/prefer-function-type": "off",
             "@typescript-eslint/unified-signatures": "off",
-            "@typescript-eslint/ban-types": "off",
+            "@typescript-eslint/no-unsafe-function-type": "off",
+            "@typescript-eslint/no-wrapper-object-types": "off",
             "@typescript-eslint/no-unused-vars": "off",
 
             // scripts/eslint/rules