assertNever no longer crashes on string input (#29764)

microsoft · Feb 6, 2019 · 33af4ea · 33af4ea
1 parent 4505eea
commit 33af4ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -1652,7 +1652,7 @@ namespace ts {
         }
 
         export function assertNever(member: never, message = "Illegal value:", stackCrawlMark?: AnyFunction): never {
-            const detail = "kind" in member && "pos" in member ? "SyntaxKind: " + showSyntaxKind(member as Node) : JSON.stringify(member);
+            const detail = typeof member === "object" && "kind" in member && "pos" in member ? "SyntaxKind: " + showSyntaxKind(member as Node) : JSON.stringify(member);
             return fail(`${message} ${detail}`, stackCrawlMark || assertNever);
         }
 

diff --git a/src/testRunner/unittests/asserts.ts b/src/testRunner/unittests/asserts.ts
@@ -5,5 +5,8 @@ namespace ts {
             assert.throws(() => assert.deepEqual(createNodeArray([], /*hasTrailingComma*/ true), createNodeArray([], /*hasTrailingComma*/ false)));
             assert.deepEqual(createNodeArray([createIdentifier("A")], /*hasTrailingComma*/ true), createNodeArray([createIdentifier("A")], /*hasTrailingComma*/ true));
         });
+        it("assertNever on string has correct error", () => {
+            assert.throws(() => Debug.assertNever("hi" as never), "Debug Failure. Illegal value: \"hi\"");
+        });
     });
 }