Fixed a crash when trying to find references on `NoSubstitutionTempla…

…teLiteral` with `LiteralType` parent (#59889)
microsoft · Sep 19, 2024 · 8880946 · 8880946
1 parent 9f150e0
commit 8880946
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -4227,7 +4227,9 @@ export function tryGetImportFromModuleSpecifier(node: StringLiteralLike): AnyVal
         case SyntaxKind.CallExpression:
             return isImportCall(node.parent) || isRequireCall(node.parent, /*requireStringLiteralLikeArgument*/ false) ? node.parent as RequireOrImportCall : undefined;
         case SyntaxKind.LiteralType:
-            Debug.assert(isStringLiteral(node));
+            if (!isStringLiteral(node)) {
+                break;
+            }
             return tryCast(node.parent.parent, isImportTypeNode) as ValidImportTypeNode | undefined;
         default:
             return undefined;

diff --git a/tests/baselines/reference/findAllRefsNoSubstitutionTemplateLiteralNoCrash1.baseline.jsonc b/tests/baselines/reference/findAllRefsNoSubstitutionTemplateLiteralNoCrash1.baseline.jsonc
@@ -0,0 +1,23 @@
+// === findAllReferences ===
+// === /tests/cases/fourslash/findAllRefsNoSubstitutionTemplateLiteralNoCrash1.ts ===
+// type Test = `[|{| isInString: true |}T|]/*FIND ALL REFS*/`;
+
+  // === Definitions ===
+  // === /tests/cases/fourslash/findAllRefsNoSubstitutionTemplateLiteralNoCrash1.ts ===
+  // type Test = `[|T|]/*FIND ALL REFS*/`;
+
+  // === Details ===
+  [
+   {
+    "containerKind": "",
+    "containerName": "",
+    "kind": "var",
+    "name": "T",
+    "displayParts": [
+     {
+      "text": "`T`",
+      "kind": "stringLiteral"
+     }
+    ]
+   }
+  ]
diff --git a/tests/cases/fourslash/findAllRefsNoSubstitutionTemplateLiteralNoCrash1.ts b/tests/cases/fourslash/findAllRefsNoSubstitutionTemplateLiteralNoCrash1.ts
@@ -0,0 +1,5 @@
+/// <reference path='fourslash.ts' />
+
+//// type Test = `T/*1*/`;
+
+verify.baselineFindAllReferences('1');