Handle if plugin doesnt specify name (#42720)

Fixes microsoft/vscode#116219
microsoft · Feb 9, 2021 · af0ad80 · af0ad80
1 parent c329d68
commit af0ad80
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/server/project.ts b/src/server/project.ts
@@ -1569,8 +1569,8 @@ namespace ts.server {
 
         protected enablePlugin(pluginConfigEntry: PluginImport, searchPaths: string[], pluginConfigOverrides: Map<any> | undefined) {
             this.projectService.logger.info(`Enabling plugin ${pluginConfigEntry.name} from candidate paths: ${searchPaths.join(",")}`);
-            if (parsePackageName(pluginConfigEntry.name).rest) {
-                this.projectService.logger.info(`kipped loading plugin ${pluginConfigEntry.name} because only package name is allowed plugin name`);
+            if (!pluginConfigEntry.name || parsePackageName(pluginConfigEntry.name).rest) {
+                this.projectService.logger.info(`Skipped loading plugin ${pluginConfigEntry.name || JSON.stringify(pluginConfigEntry)} because only package name is allowed plugin name`);
                 return;
             }
 

diff --git a/src/testRunner/unittests/tsserver/plugins.ts b/src/testRunner/unittests/tsserver/plugins.ts
@@ -24,7 +24,12 @@ namespace ts.projectSystem {
             const tsconfig: File = {
                 path: "/tsconfig.json",
                 content: JSON.stringify({
-                    compilerOptions: { plugins: [...expectedToLoad, ...notToLoad].map(name => ({ name })) }
+                    compilerOptions: {
+                        plugins: [
+                            ...[...expectedToLoad, ...notToLoad].map(name => ({ name })),
+                            { transform: "some-transform" }
+                        ]
+                    }
                 })
             };
             const { host, pluginsLoaded } = createHostWithPlugin([aTs, tsconfig, libFile]);