Go back to using explicit node verisons in CI (#51965)

Fixes #51943
microsoft · Dec 19, 2022 · ef70a28 · ef70a28
1 parent 70ee780
commit ef70a28
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,11 +16,11 @@ jobs:
 
     strategy:
       matrix:
-        # Test the latest version of Node.js plus the last two LTS versions.
         node-version:
-          - "*"
-          - lts/*
-          - lts/-1
+          - "19"
+          - "18"
+          - "16"
+          - "14"
         bundle:
           - "true"
         include:

diff --git a/src/compiler/watch.ts b/src/compiler/watch.ts
@@ -172,7 +172,12 @@ function getPlainDiagnosticFollowingNewLines(diagnostic: Diagnostic, newLine: st
 export function getLocaleTimeString(system: System) {
     return !system.now ?
         new Date().toLocaleTimeString() :
-        system.now().toLocaleTimeString("en-US", { timeZone: "UTC" });
+        // On some systems / builds of Node, there's a non-breaking space between the time and AM/PM.
+        // This branch is solely for testing, so just switch it to a normal space for baseline stability.
+        // See:
+        //     - https://github.com/nodejs/node/issues/45171
+        //     - https://github.com/nodejs/node/issues/45753
+        system.now().toLocaleTimeString("en-US", { timeZone: "UTC" }).replace("\u202f", " ");
 }
 
 /**