-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quick fix to install module definitions from @types #14423
Comments
We need to support this both as:
For both the quick fix and the refactor, the edit will be empty, since there is no code change, so we will need to add a new property on the API to signal the editor to call back to install types with some arguments (being the type to install, and the location of the package.json). //CC @mjbvz |
We also need to handle case if the package does not have any definitions available. in this case we need to create a new .d.ts file for it.. @andy-ms please check with @DanielRosenwasser about details of this one. |
Would the install command be configurable? |
Fixed by #19130 |
@mhegazy Do we want to open a new issue for yarn support? |
created #19269 to track that. |
If a module was not found, or only js file was found, a quick fix can be offered to install the module from @types.
The text was updated successfully, but these errors were encountered: