Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support yarn in Install @types/<package> code fix #19269

Open
mhegazy opened this issue Oct 17, 2017 · 2 comments
Open

Support yarn in Install @types/<package> code fix #19269

mhegazy opened this issue Oct 17, 2017 · 2 comments
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Quick Fixes Editor-provided fixes, often called code actions. Suggestion An idea for TypeScript

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Oct 17, 2017

#19130 added a code fix to install packages from @types. This will always use npm to install the package. This works for updating package.json and package-lock.json, but not yarn.lock
@mhegazy mhegazy added Domain: Quick Fixes Editor-provided fixes, often called code actions. Suggestion An idea for TypeScript Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature labels Oct 17, 2017
@mhegazy mhegazy mentioned this issue Oct 17, 2017
Closed
@DanielRosenwasser DanielRosenwasser changed the title Support yarn in Install @types\<package> code fix Support yarn in Install @types/<package> code fix Oct 18, 2017
@mjbvz mjbvz mentioned this issue Jan 31, 2018
Closed
@mjbvz mjbvz mentioned this issue Oct 9, 2018
Closed
@tomasaschan
Copy link

I would like this to happen. However, according to CONTRIBUTING.md I shouldn't create a PR for something that isn't tagged Milestone == Community and has been approved by a contributor.

Would you reconsider this issue and accept a PR that tries to accomplish this?

@mjbvz mjbvz mentioned this issue May 23, 2019
Closed
@QuentinRoy
Copy link

Actually, it would be great to make this configurable. yarn and npm are not the only players. pnpm is another popular package manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Quick Fixes Editor-provided fixes, often called code actions. Suggestion An idea for TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@QuentinRoy @tomasaschan @mhegazy