Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install @types quick fix can erase node modules installed with yarn #21504

Closed
mjbvz opened this issue Jan 31, 2018 · 3 comments
Closed

Install @types quick fix can erase node modules installed with yarn #21504

mjbvz opened this issue Jan 31, 2018 · 3 comments
Labels
Duplicate An existing issue was already created

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jan 31, 2018

TypeScript Version: 2.7.0-dev.20180127

Search Terms:

  • Install @types quick fix
  • Yarn

microsoft/vscode#42535

Code

  1. In a new project:

  2. $ npm init -y
    $ yarn request lodash
    
  3. In a ts file in the project:

    import * as r from 'request'
  4. Trigger quick fix to install @types for request

Expected behavior:
Installs @types/request

Actual behavior:
Installs but also seems to erase other installed node_modules. See microsoft/vscode#42535

Related Issues:

@octref
Copy link

octref commented Jan 31, 2018

@mjbvz Should be yarn add request lodash.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 31, 2018

Currently the install action uses npm install -D. Yarn support is tracked by #19269

@mhegazy mhegazy added the Duplicate An existing issue was already created label Jan 31, 2018
@typescript-bot
Copy link
Collaborator

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

4 participants