Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.property completion does not include insertText if in parens #21320

Closed
mjbvz opened this issue Jan 20, 2018 · 0 comments
Closed

this.property completion does not include insertText if in parens #21320

mjbvz opened this issue Jan 20, 2018 · 0 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jan 20, 2018

TypeScript 2.7.0-2018-01-19

Code
For the js:

class Circle {
    constructor(radius) {
        this.radius = radius
    }

    foo() {
        return (rad)
    }
}

Trigger suggestions at the end of rad in return (rad)

Expected behavior:
Returned completion for radius includes insertText that turns the expression into (this.radius)

Actual behavior:
Returned completion does not include insertText:

 {
        "name": "radius",
        "kind": "property",
        "kindModifiers": "",
        "sortText": "0"
    },
    {
        "name": "radius",
        "kind": "warning",
        "kindModifiers": "",
        "sortText": "1"
    },
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Jan 20, 2018
@DanielRosenwasser DanielRosenwasser added the Bug A bug in TypeScript label Jan 21, 2018
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 2.7.1 milestone Jan 21, 2018
@mjbvz mjbvz changed the title this.property completion not include insertText if in parens this.property completion does not include insertText if in parens Jan 23, 2018
@ghost ghost closed this as completed in #21330 Jan 25, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 25, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

3 participants