Fix bug: Support this. completions even when isGlobalCompletion is false
#21330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
#11338 added isGlobalCompletion |
This was referenced Jan 22, 2018
mhegazy
approved these changes
Jan 24, 2018
|
We also need to move this to release-2.7 |
ghost
pushed a commit
that referenced
this pull request
Jan 25, 2018
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Jan 25, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21320
Does anyone know why we return
isGlobalCompletionas part of aCompletionInfoand why it is not true in an expression context?