Import namespace exports should be immutable

[JsonFreeman]

We should not allow mutating a property of a namespace import:

// Library
export var x = 1;

// Consumer
import * as stuff from 'Library';
stuff.x = 0;

In ES6, these bindings are immutable.

[JsonFreeman]

Why was the fix for this reverted?

[mhegazy]

it breaks existing module import syntax. The fix did not handle all cases correctly. we probably need to do it "right" by adding a readonly flag on the type and checking it everywhere.

[JsonFreeman]

To clarify, this breaks the import blah = require(...) scenario. We'd have to disallow this only for properties of namespaces.

[Arnavion]

Fixed by #6532 ( e506378 )?

[JsonFreeman]

If the exports on the namespace objects are marked readonly, then yes.