configFileDiag not returning errors for missing project reference path

[mjbvz]

TypeScript Version: 3.0.1-insider.20180713

Search Terms:

• tsconfig
• configFileDiag
• tsserver

Code
Create a simple tsconfig that references a non-existant project path:

{
    "references": [
        {
            "path": "./no-such-tsconfig.json"
        }
    ]
}

Save the file and see a configFileDiag response from tsserver

Expected behavior:
configFileDiag returns a diagnostic for the invalid path

Actual behavior:
No diagnostics are returned

Let me know if there is another way we are supposed to be getting diagnostics for config file issues.

Related Issues:

• TSServer: config file diagnostics are missing start / end property #10384

[sheetalkamat]

These errors are reported as compilerOptions diagnostics just like when having tsconfig.json as:

{ "compilerOptions": {
    "allowJs": true,
"declaration": true
}
}

will report errors

tsconfig.json:2:5 - error TS5053: Option 'allowJs' cannot be specified with option 'declaration'.

2     "allowJs": true,
      ~~~~~~~~~

tsconfig.json:3:1 - error TS5053: Option 'allowJs' cannot be specified with option 'declaration'.

3 "declaration": true
  ~~~~~~~~~~~~~

You need to be calling semanticDiagnosticsSync on configFile when project is open to get these errors.

[mhegazy]

@sheetalkamat should not this be in ConfigFileDiagnosticEvent instead? VSCode does not use any of the sync APIs and nor should they. I think we either need to send the errors back in the event or in the getErr command.