Newly created files don't belong to ts-project

[jrieken]

TS Issue template filled out by @mjbvz from original report

TypeScript Version: 3.7.3

Repo steps:

1. In the VS Code code base
2. Open src/vs/workbench/contrib/codeActions/common/codeActions.contribution.ts
3. Wait for JS/TS to finish initializing
4. Select the lines:

Registry.as<IConfigurationRegistry>(Extensions.Configuration)
	.registerConfiguration(editorConfiguration);

4. Run the move to new file refactoring

Bug
The newly created file is not part of any project

[mjbvz]

Here's a tsserver.log for the above repo. The important bit is that newFile.ts is stuck in a new inferred project instead of the main project:

Info 2398 [17:57:12.924] Open files: 
Info 2398 [17:57:12.924] 	FileName: /Users/matb/projects/vscode/src/vs/workbench/contrib/codeActions/common/codeActions.contribution.ts ProjectRootPath: /Users/matb/projects/vscode
Info 2398 [17:57:12.924] 		Projects: /Users/matb/projects/vscode/src/tsconfig.json
Info 2398 [17:57:12.924] 	FileName: /Users/matb/projects/vscode/src/vs/workbench/contrib/codeActions/common/newFile.ts ProjectRootPath: /Users/matb/projects/vscode
Info 2398 [17:57:12.925] 		Projects: /dev/null/inferredProject1*

[mjbvz]

Just tested this in typescript: 3.8.0-dev.20191219 and it seems to work properly

@jrieken Can you also please try upgrading to use typescript@next by installing this extension. Try using that version of TS for a few days while working on VS Code and let us know if you hit the problem again

[jrieken]

This also happens with 3.8.0-dev.20201009

[sheetalkamat]

I don't seem to repro this...

tsserver.log

Can you get the latest tsserver log, may be it will reveal something.

Info 2348 [10:35:38.323] Open files: 
Info 2348 [10:35:38.323] 	FileName: c:/github/vscode/src/vs/workbench/contrib/codeActions/common/codeActions.contribution.ts ProjectRootPath: c:/github/vscode
Info 2348 [10:35:38.323] 		Projects: c:/github/vscode/src/tsconfig.json
Info 2348 [10:35:38.323] 	FileName: c:/github/vscode/src/vs/workbench/contrib/codeActions/common/newFile.ts ProjectRootPath: c:/github/vscode
Info 2348 [10:35:38.323] 		Projects: c:/github/vscode/src/tsconfig.json

[jrieken]

tsserver.log

There you go - created callHierarchyFoo.ts and copied this import import { IModelService } from 'vs/editor/common/services/modelService'; which yields in a compile error. Using ts 3.8.0-dev-20200111

[sheetalkamat]

@jrieken Thank you for the log.. This seems to arise only if the file creation watcher is invoked after file is opened (because of some perf optimized code we have on how we handle new file that is open created/deleted).

[realh]

This seems to arise only if the file creation watcher is invoked after file is opened (because of some perf optimized code we have on how we handle new file that is open created/deleted).

So it's some sort of race condition? In #88787 I mentioned my project was on a sshfs mount (via wifi). Could the lag from the filing system be exacerbating it?

[lstkz]

@sheetalkamat
Is it possible to include this fix to 3.7? 🙏
As described here microsoft/vscode#88660, this issue is very frustrating for me. Sometimes, I must restart TS from the command pallet 20 times per day 😕

[orta]

Independent of the release, you can use this extension to use an up-to-date copy of the TS tooling for VS code. ( Once the PR is merged )

[lstkz]

Does 3.8.0-dev.20200125 include this commit or I have to wait for 0126? I was able to repeat this issue in 0125.

[lstkz]

@orta @sheetalkamat
The issue is not fixed. I am able to reproduce it in 3.8.0-dev.20200128.

[sheetalkamat]

@BetterCallSKY The original repro is fixed. I verified it again just to make sure. You would need to create new issue with repro to be able to investigate this.

[lstkz]

@sheetalkamat
I created here microsoft/vscode#88660, but it's closed.

#35794 (comment)
My tsserver.log is very similar. When I create a new file, VSCode/TS creates a new project for it.

[sheetalkamat]

You would want to create new issue in typescript repo with repro and tsserver log since the log mentioned in comment is exact repro I see as fixed.