Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewErrors] 4.5.0-dev.20211017 vs 4.4.4 #46404

Closed
typescript-bot opened this issue Oct 17, 2021 · 8 comments
Closed

[NewErrors] 4.5.0-dev.20211017 vs 4.4.4 #46404

typescript-bot opened this issue Oct 17, 2021 · 8 comments

Comments

@typescript-bot
Copy link
Collaborator

The following errors were reported by 4.5.0-dev.20211017, but not by 4.4.4

typeorm/typeorm

tsconfig.json

react-hook-form/react-hook-form

2 of 3 projects failed to build with the old tsc

tsconfig.json

statelyai/xstate

5 of 17 projects failed to build with the old tsc

examples/template-svelte-ts/tsconfig.json

examples/todo-mvc-svelte/tsconfig.json

packages/xstate-inspect/tsconfig.json

packages/xstate-test/tsconfig.json

@sandersn
Copy link
Member

The excessive stack depth in FindConditions is from a structural comparison of a class to an empty subclass. I'll bisect it to find out what caused it. Possibly related to #45672?

@sandersn
Copy link
Member

The excessive stack depth in react-hook-form happens during type parameter inference, but that's all I know right now.

@sandersn
Copy link
Member

It is fixed by #46429.

@sandersn
Copy link
Member

Here's a standalone repro for FindConditions's excessive stack depth error. I'm going to bisect to find out when it started failing.

class FindOperator<T> { }
type FindConditions<T> = {
    [P in keyof T]?: FindConditions<T[P]> | FindOperator<FindConditions<T[P]>>;
};
declare class Repository<Entity extends {[key: string]: any;}> {
    update(criteria: object|FindConditions<Entity>): void
}
class MR<Entity> extends Repository<Entity> {
}

export function repro(): any {
  const x: Repository<any> = new MR()
  return x
}

@andrewbranch
Copy link
Member

On the Cannot find module './App.svelte' or its corresponding type declarations. ones, I’m not sure how this would have been working before; we don’t resolve non-JS/TS file extensions in tsc.

5 of 17 projects failed to build with the old tsc

Oh wait, what does this mean? Are these errors not new? @amcasey

@amcasey
Copy link
Member

amcasey commented Oct 22, 2021

That means that 5 of 17 projects were considered not to have valid baselines and new errors from those projects were not reported.

In general, only errors in projects that built cleanly with the baseline compiler are reported in these bugs.

@sandersn
Copy link
Member

FindCondition's excessive stack depth error is from #41821, which is not too surprising, we must have been hitting Maybe before.

@sandersn
Copy link
Member

sandersn commented Oct 25, 2021

The two xstate examples don't repro locally, which is not surprising.
Edit: The two errors in xstate packages also don't repro, which is surprising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants