-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NewErrors] 4.5.0-dev.20211017 vs 4.4.4 #46404
Comments
The excessive stack depth in FindConditions is from a structural comparison of a class to an empty subclass. I'll bisect it to find out what caused it. Possibly related to #45672? |
The excessive stack depth in react-hook-form happens during type parameter inference, but that's all I know right now. |
It is fixed by #46429. |
Here's a standalone repro for FindConditions's excessive stack depth error. I'm going to bisect to find out when it started failing. class FindOperator<T> { }
type FindConditions<T> = {
[P in keyof T]?: FindConditions<T[P]> | FindOperator<FindConditions<T[P]>>;
};
declare class Repository<Entity extends {[key: string]: any;}> {
update(criteria: object|FindConditions<Entity>): void
}
class MR<Entity> extends Repository<Entity> {
}
export function repro(): any {
const x: Repository<any> = new MR()
return x
} |
On the
Oh wait, what does this mean? Are these errors not new? @amcasey |
That means that 5 of 17 projects were considered not to have valid baselines and new errors from those projects were not reported. In general, only errors in projects that built cleanly with the baseline compiler are reported in these bugs. |
FindCondition's excessive stack depth error is from #41821, which is not too surprising, we must have been hitting |
The two xstate examples don't repro locally, which is not surprising. |
The following errors were reported by 4.5.0-dev.20211017, but not by 4.4.4
typeorm/typeorm
tsconfig.json
error TS2548: Type '{ [x: string]: any; }' is not an array type or does not have a '[Symbol.iterator]()' method that returns an iterator.
error TS2321: Excessive stack depth comparing types 'FindConditions<any>' and 'FindConditions<Entity>'.
react-hook-form/react-hook-form
2 of 3 projects failed to build with the old tsc
tsconfig.json
error TS2589: Type instantiation is excessively deep and possibly infinite.
statelyai/xstate
5 of 17 projects failed to build with the old tsc
examples/template-svelte-ts/tsconfig.json
error TS2307: Cannot find module './App.svelte' or its corresponding type declarations.
examples/todo-mvc-svelte/tsconfig.json
error TS2307: Cannot find module './App.svelte' or its corresponding type declarations.
packages/xstate-inspect/tsconfig.json
error TS2344: Type 'TSchema["states"][K]' does not satisfy the constraint 'Required<Pick<StateSchema<any>, "states">>'.
packages/xstate-test/tsconfig.json
error TS2344: Type 'TSchema["states"][K]' does not satisfy the constraint 'Required<Pick<StateSchema<any>, "states">>'.
The text was updated successfully, but these errors were encountered: