Salsa doesn't show any outline for this source code

[egamma]

From @alexandrudima on January 27, 2016 10:39

Testing #2218

No jsconfig.json

exports.something = function() {
    return true;
}

Copied from original issue: microsoft/vscode#2427

[billti]

something is not available at the global scope. It is a property of an object. The symbol list generally doesn't show these. Why would this be expected here? Should exports get special behavior (even though they are symbols you cannot just directly reference).

[alexdima]

Well, imagine the following use-case: I have configured the module system to be commonjs. I am in a consumer of the module and do Ctrl-Space on the module. I get to see something plus possibly many other exported symbols. I then navigate to the producer module and want to iterate through its exported APIs. Not critical, but would be nice :)

[billti]

It seems reasonable. Things exported are conceptually 'top level' in how you thing about a module. Ryan, how hard would it be to surface CommonJS style exports as top level items for navigation?

[RyanCavanaugh]

@egamma What API does VS Code use to populate the list?

[billti]

I believe it is the 'navbar' command VSCode side and TypeScript side (or perhaps 'navto'?)

[billti]

Note: Just stepped into it in the debugger - it is 'navbar', which ultimately calls into getNavigationBarItems.

[billti]

Need to come up with a design for this. This is neither a function declaration, nor a global value, so we don't put it in the nav bar today. Arguably we should treat exports specially here.

[billti]

Changing the navbar for TypeScript and JavaScript would be quite invasive at this late point for 1.8, but seeing as the JavaScript support is quite new, we can special case JavaScript behavior to temporarily make this experience better, then work to align the JavaScript and TypeScript (and 'navbar' and 'navto' logic) longer term.

After discussion with @egamma, @jrieken, and @mhegazy , I've come up with something like can be seen below. The logic is contained in this commit (not yet merged anywhere).

Basically any function/method is a container of other items. They are named by either the given name, or the property/variable they are assigned to (e.g. exports.foo), or just <function> if nothing else can be inferred. If a function expression is named <function> and does not contain other items, then this is not added to the navbar (to avoid pollution with lots of little lambda expressions). This also recognizes define calls and adds it as a module, with either the name given in the first arg, or the containing file name.

It needs a little tidy up (e.g. getters/setters aren't done yet) and hardening, but let me know if this looks good for your needs.

[jrieken]

👍

[egamma]

This looks good and it is a huge improvement 👍

[warpdesign]

@billti nice! Will it solve problems with closures as well ? See #7134