Improve NavBar experience for JavaScript files #7504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <reference path='services.ts' /> | ||
|
|
||
| /* @internal */ | ||
| namespace ts.NavigationBar { | ||
| export function getJsNavigationBarItems(sourceFile: SourceFile, compilerOptions: CompilerOptions): NavigationBarItem[] { |
There was a problem hiding this comment.
Can you move this below getNavigationBarItems? Generally we have helper functions cascading below the entry point.
| declarationNameToString((node as (Declaration)).name); | ||
|
|
||
| const elementKind = |
There was a problem hiding this comment.
Refactor this into a function with a switch
There was a problem hiding this comment.
Anders says it fine, so like... whatever :-p
|
👍 |
| case SyntaxKind.SetAccessor: | ||
| // "export default function().." looks just like a regular function/class declaration, except with the 'default' flag set | ||
| const name = node.flags && (node.flags & NodeFlags.Default) ? "default" : |
There was a problem hiding this comment.
I think you only want to do this if the function/class declaration doesn't have a name - otherwise, you're more likely to be concerned with its local name.
|
All right, you guys win :-p Latest commit should address nearly all the feedback. Thanks! |
billti
added a commit
that referenced
this pull request
Mar 15, 2016
Improve NavBar experience for JavaScript files
billti
added a commit
that referenced
this pull request
Mar 15, 2016
Port of #7504 (improve NavBar for JS files)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in #6644 .
Note the test harness is not well suited to NavBar tests currently where the NavBar items are actually hierarchical (which they are with this code), so I'll need to do some additional work here. I've manually tested this quite heavily, and it is JavaScript specific, so won't impact TypeScript NavBar operation.
Getting this out for code review now, as VSCode wants this ASAP to start locking down their next release.