Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSDoc does not appear to work for ES6 class ctors #6646

Closed
egamma opened this issue Jan 27, 2016 · 0 comments
Closed

JSDoc does not appear to work for ES6 class ctors #6646

egamma opened this issue Jan 27, 2016 · 0 comments
Assignees
@RyanCavanaugh
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 1.8.2

Comments

@egamma
Copy link
Member

egamma commented Jan 27, 2016

From @alexandrudima on January 27, 2016 14:54

Testing #2218

a is not recognised as a number.

"use strict";

class Something {

    /**
     * @param {number} a
     */
    constructor(a, b) {
        a.
    }
}

Copied from original issue: microsoft/vscode#2460
@egamma egamma self-assigned this Jan 27, 2016
@egamma egamma mentioned this issue Jan 27, 2016
Closed
@billti billti added this to the Salsa 0.9 milestone Jan 27, 2016
@billti billti assigned RyanCavanaugh and unassigned egamma Jan 27, 2016
@billti billti added the Bug A bug in TypeScript label Jan 27, 2016
RyanCavanaugh added a commit to RyanCavanaugh/TypeScript that referenced this issue Jan 27, 2016
@RyanCavanaugh
Parse JSDoc comments for ES6 class constructors and methods
1b282cd 
Fixes microsoft#6646
@RyanCavanaugh RyanCavanaugh mentioned this issue Jan 27, 2016
Merged
@RyanCavanaugh RyanCavanaugh added the Fixed A PR has been merged for this issue label Jan 28, 2016
@mhegazy mhegazy modified the milestones: Salsa 0.9, TypeScript 1.8.2 Feb 2, 2016
billti pushed a commit that referenced this issue Feb 4, 2016
@RyanCavanaugh @billti
Parse JSDoc comments for ES6 class constructors and methods
eb27166 
Fixes #6646

(cherry picked from commit 1b282cd)
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RyanCavanaugh RyanCavanaugh

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 1.8.2
Development

No branches or pull requests
4 participants
@egamma @billti @RyanCavanaugh @mhegazy