First in UMD global wins #10354
Merged
First in UMD global wins #10354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Merge in UMD exports with first-in-wins semantics (see #9771) | ||
| const source = file.symbol.globalExports; | ||
| for (const id in source) { | ||
| if (hasProperty(source, id) && !hasProperty(globals, id)) { |
There was a problem hiding this comment.
I don't think you need to check hasProperty(source, id) since we switch to use new "Map"? same as !hasProperty(globals, id) could you just use indexer? though not sure we allow key mapped to undefined or not
|
Lgtm after smalle comments |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9771