Fix crash when checking module exports for export= #10538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make maxNodeModuleJsDepth default to 0 so that incorrect tsconfigs now let the compiler spend less time compiling JS that is found in node_modules (especially since most people will already have the d.ts and want ignore the JS anyway). jsconfig still defaults to 2.
|
@andy-ms and @vladima can you take a look? |
|
@mhegazy you should also know about this fix. |
| // @traceResolution: true | ||
| // @noEmit: true | ||
|
|
||
| // @filename: c:/root/tsconfig.json |
|
👍 |
This was referenced Aug 25, 2016
| /// <reference path="c:/root/typings/index.d.ts" /> | ||
| import * as foo from "shortid"; | ||
| foo.x // found in index.d.ts | ||
| foo.y // ignored from shortid/index.ts |
There was a problem hiding this comment.
shortid/index.js and not shortid/index.ts.
|
can you add the same test with maxNodeModuleJsDepth == 1 and then the error message should be on |
|
👍 |
|
Actually if there is a d.ts, then it is always used. There is no way to get the compiler to prefer |
| @@ -4,7 +4,7 @@ | |||
| // @traceResolution: true | |||
| // @noEmit: true | |||
|
|
|||
| // @filename: c:/root/tsconfig.json | |||
| // @filename: tsconfig.json | |||
There was a problem hiding this comment.
You need to include the / in front or else your own directory will show up in the trace.
There was a problem hiding this comment.
good to know, I didn't notice that. fixed.
|
Travis is down, but all tests pass when I merge master back into the branch, so I'll go ahead and merge. @yuit |
This was referenced Jul 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10460 and fixes #10522
This PR also makes maxNodeModuleJsDepth default to 0 so that incorrect tsconfigs now let the compiler spend less time compiling JS that is found in node_modules (especially since most people will already have the d.ts and want ignore the JS anyway).
jsconfig still defaults to 2.