Show an elaboration when accessing a non-existent property of a union type #10582
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| tests/cases/compiler/propertyAccess3.ts(2,5): error TS2339: Property 'toBAZ' does not exist on type 'boolean'. | ||
| Property 'toBAZ' does not exist on type 'true'. | ||
|
|
||
|
|
||
| ==== tests/cases/compiler/propertyAccess3.ts (1 errors) ==== | ||
| var foo: boolean; | ||
| foo.toBAZ(); | ||
| ~~~~~ | ||
| !!! error TS2339: Property 'toBAZ' does not exist on type 'boolean'. | ||
| !!! error TS2339: Property 'toBAZ' does not exist on type 'true'. | ||
|
There was a problem hiding this comment. This looks weird - let's exclude There was a problem hiding this comment. Eugh. How about for enums and booleans we don't dive in? Specifically, you can check There was a problem hiding this comment. Great minds think and read GitHub on Sunday nights alike There was a problem hiding this comment. Actually, There was a problem hiding this comment. Wow GitHub syncs weird-like There was a problem hiding this comment.
declare const x: "foo" | "bar";
x.nope(); |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| tests/cases/compiler/unionPropertyExistance.ts(24,4): error TS2339: Property 'onlyInB' does not exist on type 'AB'. | ||
|
There was a problem hiding this comment. Can you rename the file |
||
| Property 'onlyInB' does not exist on type 'A'. | ||
| tests/cases/compiler/unionPropertyExistance.ts(27,5): error TS2339: Property 'notInC' does not exist on type 'ABC'. | ||
| Property 'notInC' does not exist on type 'C'. | ||
| tests/cases/compiler/unionPropertyExistance.ts(28,4): error TS2339: Property 'notInB' does not exist on type 'AB'. | ||
| Property 'notInB' does not exist on type 'B'. | ||
| tests/cases/compiler/unionPropertyExistance.ts(29,5): error TS2339: Property 'notInB' does not exist on type 'ABC'. | ||
| Property 'notInB' does not exist on type 'B'. | ||
| tests/cases/compiler/unionPropertyExistance.ts(32,5): error TS2339: Property 'inNone' does not exist on type 'ABC'. | ||
| Property 'inNone' does not exist on type 'A'. | ||
|
|
||
|
|
||
| ==== tests/cases/compiler/unionPropertyExistance.ts (5 errors) ==== | ||
| interface A { | ||
| inAll: string; | ||
| notInB: string; | ||
| notInC: string; | ||
| } | ||
|
|
||
| interface B { | ||
| inAll: boolean; | ||
| onlyInB: number; | ||
| notInC: string; | ||
| } | ||
|
|
||
| interface C { | ||
| inAll: number; | ||
| notInB: string; | ||
| } | ||
|
|
||
| type AB = A | B; | ||
| type ABC = C | AB; | ||
|
|
||
| var ab: AB; | ||
| var abc: ABC; | ||
|
|
||
| ab.onlyInB; | ||
| ~~~~~~~ | ||
| !!! error TS2339: Property 'onlyInB' does not exist on type 'AB'. | ||
| !!! error TS2339: Property 'onlyInB' does not exist on type 'A'. | ||
|
|
||
| ab.notInC; // Ok | ||
| abc.notInC; | ||
| ~~~~~~ | ||
| !!! error TS2339: Property 'notInC' does not exist on type 'ABC'. | ||
| !!! error TS2339: Property 'notInC' does not exist on type 'C'. | ||
| ab.notInB; | ||
| ~~~~~~ | ||
| !!! error TS2339: Property 'notInB' does not exist on type 'AB'. | ||
| !!! error TS2339: Property 'notInB' does not exist on type 'B'. | ||
| abc.notInB; | ||
| ~~~~~~ | ||
| !!! error TS2339: Property 'notInB' does not exist on type 'ABC'. | ||
| !!! error TS2339: Property 'notInB' does not exist on type 'B'. | ||
|
|
||
| abc.inAll; // Ok | ||
| abc.inNone; | ||
| ~~~~~~ | ||
| !!! error TS2339: Property 'inNone' does not exist on type 'ABC'. | ||
| !!! error TS2339: Property 'inNone' does not exist on type 'A'. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| //// [unionPropertyExistance.ts] | ||
| interface A { | ||
| inAll: string; | ||
| notInB: string; | ||
| notInC: string; | ||
| } | ||
|
|
||
| interface B { | ||
| inAll: boolean; | ||
| onlyInB: number; | ||
| notInC: string; | ||
| } | ||
|
|
||
| interface C { | ||
| inAll: number; | ||
| notInB: string; | ||
| } | ||
|
|
||
| type AB = A | B; | ||
| type ABC = C | AB; | ||
|
|
||
| var ab: AB; | ||
| var abc: ABC; | ||
|
|
||
| ab.onlyInB; | ||
|
|
||
| ab.notInC; // Ok | ||
| abc.notInC; | ||
| ab.notInB; | ||
| abc.notInB; | ||
|
|
||
| abc.inAll; // Ok | ||
| abc.inNone; | ||
|
|
||
| //// [unionPropertyExistance.js] | ||
| var ab; | ||
| var abc; | ||
| ab.onlyInB; | ||
| ab.notInC; // Ok | ||
| abc.notInC; | ||
| ab.notInB; | ||
| abc.notInB; | ||
| abc.inAll; // Ok | ||
| abc.inNone; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| interface A { | ||
| inAll: string; | ||
| notInB: string; | ||
| notInC: string; | ||
| } | ||
|
|
||
| interface B { | ||
| inAll: boolean; | ||
| onlyInB: number; | ||
| notInC: string; | ||
| } | ||
|
|
||
| interface C { | ||
| inAll: number; | ||
| notInB: string; | ||
| } | ||
|
|
||
| type AB = A | B; | ||
| type ABC = C | AB; | ||
|
|
||
| var ab: AB; | ||
| var abc: ABC; | ||
|
|
||
| ab.onlyInB; | ||
|
|
||
| ab.notInC; // Ok | ||
| abc.notInC; | ||
| ab.notInB; | ||
| abc.notInB; | ||
|
|
||
| abc.inAll; // Ok | ||
| abc.inNone; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: Nonexistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reportNonexistentProperty