Allow untyped imports #11889
Merged
Allow untyped imports #11889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Closed
ghost
force-pushed
the
untyped_imports
branch
from
3534494 to
c81fec6
Compare
ghost
force-pushed
the
untyped_imports
branch
from
c81fec6 to
4937d9c
Compare
mhegazy
approved these changes
Oct 27, 2016
| @@ -2869,6 +2869,10 @@ | |||
| "category": "Error", | |||
| "code": 6143 | |||
| }, | |||
| "A package for '{0}' was found at '{1}', but is untyped. Because '--noImplicitAny' is enabled, this package must have a declaration.": { | |||
There was a problem hiding this comment.
how about something more consistent with the rest of the the --noImplicitAny error message, e.g.: Could not find a declaration file for module '{0}'. All imports implicitly have type 'any'.
There was a problem hiding this comment.
How about: "Could not find a declaration file for module '{0}'. '{1}' implicitly has an 'any' type."
| @@ -2869,6 +2869,10 @@ | |||
| "category": "Error", | |||
| "code": 6143 | |||
| }, | |||
| "A package for '{0}' was found at '{1}', but is untyped. Because '--noImplicitAny' is enabled, this package must have a declaration.": { | |||
| "category": "Error", | |||
| "code": 6144 | |||
There was a problem hiding this comment.
make this error code in the 7000 along with the other --noImplicitAnyErrors
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11106
Replaces #11446
Made easier by #11704. No longer has to touch
moduleNameResolver.ts.