Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow primitive types in JSDoc to start wtih uppercase letters #14284

Merged
merged 1 commit into from
Feb 24, 2017
Merged

Allow primitive types in JSDoc to start wtih uppercase letters #14284

merged 1 commit into from
Feb 24, 2017
+538 −23

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Feb 24, 2017

This PR:

  • Treats Number, String, Boolean, Object, Void, Undefinded, Null, array and promise in JSDoc as number, string, boolean, any, void, undefined, null, any[] and Promise<any> respectively.
  • Remove unused JSDocNullKeyword, JSDocUndefinedKeyword and JSDocNevereyword
  • Add support for nullable JSDoc types (e.g. ?number => number | null)

Fixes #14230
Fixes #14242

@mhegazy mhegazy requested a review from sandersn February 24, 2017 05:29
@mhegazy mhegazy merged commit 1a579d1 into master Feb 24, 2017
@mhegazy mhegazy deleted the jsDocUpperCasePrimitiveTypes branch February 24, 2017 22:31
@mhegazy mhegazy added the Salsa label Mar 1, 2017
@mhegazy mhegazy mentioned this pull request Jun 1, 2017
Closed
4 tasks
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhegazy @sandersn @msftclas