Contextually type this in object literals in JS

[sandersn]

Previously, this would only get a contextual type inside object literals with --noImplicitThis turned on in Typescript files.

Fixes #16184

[DanielRosenwasser]

This is likely too restrictive - I've previously argued that what you really want is the contextual type & Record<string, any>.

[sandersn]

Isn't Record<string, any> equivalent to { [s: string]: any }? JS objects include a string indexer now, so this is legal:

const o = {
    p: 12,
    m() {
        return this.p + this.x
    }
}

And o: { p: number; m(): any; [x: string]: any }. Does that address the scenario you had in mind?

[ghost]

Add a test for unknown property. Should be no error, get any.

[weswigham]

I'm a sucker for changes that are only one line before tests. Nice one!

[sandersn]

From conversation with @andy-ms, note that if you make a call like this:

transformsPropertiesIntoMethods({
  p: 12,
  m() {
    return this.p()
  }
})

Then you will get an error with // @ts-check because the contextual type comes from the object literal but should come from the call to transformsPropertiesIntoMethods. You'll need to install types for the transformer function (ember or vue are popular libraries that work like this).