Do not inline sourcemaps in jake - source-map-support can't handle it

[weswigham]

Internally, source-map-support (which we enable during tests/debugging for sourcemapped stack traces, and recently started inspecting during tests when we stopped using a noop logger for them) uses a regexp to find the source mapping url - except with inline sources and inline source maps, we have a 25MB file it operates over. With a backtracking regexp, this sometimes triggers this v8 behavior (if the heap is in heavy use - like when we're deep inside our test suite in a single process). This was causing tests to fail on our internal CI server. Best I can tell, this doesn't happen on travis because the memory pressure is different (specifically, travis is already on node 8.3, while both myself and the CI server (the only machines which repo'd this issue) were on node 8.1.2 - best I can tell, 8.1.3 apparently reduced the memory usage of the profiler API by instantiating fewer regexes in the node profiler polyfill).

The fix is to just not use 15MB of inline sourcemaps. In the Jakefile, we were doing this to enable sourcemaps to work with runtests-browser - but we've had this working for awhile without using inline sources in our implementation in the Gulpfile. So now the Jakefile no longer builds tests with inline sourcemaps and shells out to gulp to build tests for the browser.

If you're using jake, you should not notice much of a difference in your workflow.

[rbuckton]

I would add --silent to this command to avoid all the excess gulp output.

[mihailik]

Does it blow up inside external code, or inside typescript?

If it's typescript, it would mean a bug — similar errors might show up in other use cases. For example, we're routinely inlining sources, not even sourcemaps in many of our apps. Hopefully typescript won't start to break on that?

[weswigham]

@mihailik The error is in a package we use to enable source mapped stack traces, not us. Were it in us, we'd probably just edit the RegExp/loop to not crash on 25MB files, like what was done for `convert-source-maps` awhile back.

…

On Fri, Aug 11, 2017, 3:50 AM mihailik ***@***.***> wrote: Does it blow up inside external code, or inside typescript? If it's typescript, it would mean a bug — similar errors might show up in other use cases. For example, we're routinely *inlining sources*, not even sourcemaps in many of our apps. Hopefully typescript won't start to break on that? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#17732 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACzAMhLhBTZ_62fzE_Hj_pqpe0Zex9Wlks5sXDH-gaJpZM4Oz-XC> .