Refactored typed arrays #18559

NaridaL · 2017-09-18T20:33:14Z

Fixes #15402

I based this on #18555, otherwise I'm fairly certain it would lead to merge conflicts...

Let me know if this is a problem and I'll rebase it.

NaridaL · 2017-10-17T18:45:44Z

@mhegazy a yes/no on this would be helpful on completing #18652

mhegazy · 2017-11-08T18:58:30Z

@NaridaL sorry for the delay, can you refresh the PR?

mhegazy · 2017-11-08T18:58:46Z

Changes look good to me. @rbuckton any comments?

NaridaL · 2017-11-08T19:23:08Z

While we're at it, does it make sense to rename TypedArray to BaseTypedArray have a separate type TypedArray = UInt8Array | Int8Array | ... declaration? I think it makes sense for some situations, none of which I can recall right now...

previous: ``` PS C:\Users\aval\tsdev\TypeScript> node built\local\tsc.js --diagnostics --p src\compiler\tsconfig.json Files: 36 Lines: 93186 Nodes: 445312 Identifiers: 168285 Symbols: 71668 Types: 32088 Memory used: 371617K I/O read: 0.02s I/O write: 0.17s Parse time: 0.71s Bind time: 0.62s Check time: 2.90s Emit time: 2.06s Total time: 6.29s ``` now: ``` PS C:\Users\aval\tsdev\TypeScript> node built\local\tsc.js --diagnostics --p src\compiler\tsconfig.json Files: 36 Lines: 91099 Nodes: 439748 Identifiers: 166769 Symbols: 71022 Types: 31979 Memory used: 369763K I/O read: 0.02s I/O write: 0.03s Parse time: 0.69s Bind time: 0.59s Check time: 2.92s Emit time: 1.89s Total time: 6.09s ``` Fixes microsoft#15402

NaridaL · 2017-11-08T19:47:26Z

I rebased it.

rbuckton · 2017-11-08T23:49:55Z

src/lib/es5.d.ts

-  * number of bytes could not be allocated an exception is raised.
-  */
-interface Int8Array {
+interface TypedArray<T> {


What value does the generic T give you here? You could just use the this type wherever you use T below without making TypedArray generic.

and slice and subarray don't necessarily return this if I'm not mistaken

I think we have since fixed some of the underlying issues that made it slower.

and slice and subarray don't necessarily return this if I'm not mistaken

that i do not know how to address with this...

Yes, the thisArg params can be typed with this. Is there a disadvantage to using T for for the slice/subarray return types?

We can't properly constrain the generic, so you could write a TypedArray<HTMLElement> which would not make sense.

As nice as it would be to completely deduplicate TypedArray, I don't believe that is a completely viable option at this point. As we cannot properly constrain T, I would recommend we do not make TypedArray generic at this time.

Having TypedArray generic allows for the following construct, which would type all the methods which use SpeciesConstructor correctly.

class MyInt8Array extends (Int8Array as TypedArray<MyInt8Array>) { [Symbol.species]: MyInt8Array }

If the goal is to have a common unambiguous (non-generic) supertype to which only true TypedArrays can be assigned, I would suggest #18559 (comment) which, along with an appropriate brand field, would more effectively prevent someone from assigning something which looks like a TypedArray to something which expects a real one.

What's the issue with interface TypedArray<T extends Uint16Array | Uint8Array | ...> { if you want to constrain TypedArray?

rbuckton · 2017-11-09T22:48:11Z

src/lib/es2015.iterable.d.ts

@@ -215,7 +215,7 @@ interface String {
    [Symbol.iterator](): IterableIterator<string>;
 }

-interface Int8Array {
+interface TypedArray<T> {


This should not be generic.

rbuckton · 2017-11-09T22:52:10Z

src/lib/es2015.iterable.d.ts

@@ -231,243 +231,14 @@ interface Int8Array {
    values(): IterableIterator<number>;
 }

-interface Int8ArrayConstructor {
-    new (elements: Iterable<number>): Int8Array;
+interface TypedArrayConstructor<T> {


I would rather we leave out TypedArrayConstructor entirely and leave the individual constructor interfaces.

rbuckton · 2017-11-09T22:52:36Z

src/lib/es2016.array.include.d.ts

-}
-
-interface Float64Array {
+interface TypedArray<T> {


This should not be generic.

rbuckton · 2017-11-09T22:54:50Z

src/lib/es5.d.ts

@@ -1570,7 +1566,7 @@ interface Int8Array {
      * @param thisArg An object to which the this keyword can refer in the callbackfn function.
      * If thisArg is omitted, undefined is used as the this value.
      */
-    filter(callbackfn: (value: number, index: number, array: Int8Array) => any, thisArg?: any): Int8Array;
+    filter(callbackfn: (value: number, index: number, array: this) => any, thisArg?: any): T;


Rather than return T, either return this or return TypedArray with a subtyped overload in each specific typed-array constructor (e.g. return Int32Array in the Int32Array interface).

rbuckton · 2017-11-09T22:54:59Z

src/lib/es5.d.ts

@@ -1639,7 +1635,7 @@ interface Int8Array {
      * @param thisArg An object to which the this keyword can refer in the callbackfn function.
      * If thisArg is omitted, undefined is used as the this value.
      */
-    map(callbackfn: (value: number, index: number, array: Int8Array) => number, thisArg?: any): Int8Array;
+    map(callbackfn: (value: number, index: number, array: this) => number, thisArg?: any): T;


Rather than return T, either return this or return TypedArray with a subtyped overload in each specific typed-array constructor (e.g. return Int32Array in the Int32Array interface).

rbuckton · 2017-11-09T22:55:51Z

src/lib/es5.d.ts

@@ -1708,7 +1704,7 @@ interface Int8Array {
      * @param start The beginning of the specified portion of the array.
      * @param end The end of the specified portion of the array.
      */
-    slice(start?: number, end?: number): Int8Array;
+    slice(start?: number, end?: number): T;


Rather than return T, either return this or return TypedArray with a subtyped overload in each specific typed-array constructor (e.g. return Int32Array in the Int32Array interface).

rbuckton · 2017-11-09T22:55:56Z

src/lib/es5.d.ts


    /**
      * Reverses the elements in an Array.
      */
-    reverse(): Int8Array;
+    reverse(): T;


Rather than return T, either return this or return TypedArray with a subtyped overload in each specific typed-array constructor (e.g. return Int32Array in the Int32Array interface).

rbuckton · 2017-11-09T22:57:46Z

src/lib/es5.d.ts

-  * number of bytes could not be allocated an exception is raised.
-  */
-interface Int8Array {
+interface TypedArray<T> {


As nice as it would be to completely deduplicate TypedArray, I don't believe that is a completely viable option at this point. As we cannot properly constrain T, I would recommend we do not make TypedArray generic at this time.

rbuckton · 2017-11-09T22:57:59Z

src/lib/es5.d.ts

      * at begin, inclusive, up to end, exclusive.
      * @param begin The index of the beginning of the array.
      * @param end The index of the end of the array.
      */
-    subarray(begin: number, end?: number): Int8Array;
+    subarray(begin: number, end?: number): T;


Rather than return T, either return this or return TypedArray with a subtyped overload in each specific typed-array constructor (e.g. return Int32Array in the Int32Array interface).

rbuckton · 2017-11-09T22:58:38Z

src/lib/es5.d.ts

-    new(length: number): Int8Array;
-    new(arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): Int8Array;
-    new(buffer: ArrayBufferLike, byteOffset: number, length?: number): Int8Array;
+interface TypedArrayConstructor<T> {


For now, we should leave the existing typed array constructors as is rather than introduce TypedArrayConstructor.

Alternatively, we could try the following definition:

interface TypedArrayConstructor { prototype: TypedArray; new (length: number): this["prototype"]; new (arrayOrArrayBuffer: ArrayLike<number> | ArrayBufferLike): this["prototype"]; new (buffer: ArrayBufferLike, byteOffset: number, length?: number): this["prototype"]; of(...items: number[]): this["prototype"]; from(arrayLike: ArrayLike<number>, mapfn?: (v: number, k: number) => number, thisArg?: any): this["prototype"]; } interface Int8ArrayConstructor extends TypedArrayConstructor { prototype: Int8Array; }

Though its possible this could cause problems with Symbol.species.

typescript-bot · 2018-06-12T17:40:28Z

Thanks for your contribution. This PR has not been updated in a while and cannot be automatically merged at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to continue working on this PR, please leave a message and one of the maintainers can reopen it.

msftclas added the cla-already-signed label Sep 18, 2017

NaridaL force-pushed the typedarray-dry branch from e7ae252 to fc79d85 Compare September 18, 2017 20:43

NaridaL mentioned this pull request Sep 21, 2017

Add Symbol.species to ArrayConstructor, MapConstructor, SetConstructo… #18652

Merged

msftgits removed the cla-already-signed label Sep 26, 2017

microsoft deleted a comment from msftclas Sep 27, 2017

NaridaL force-pushed the typedarray-dry branch from fc79d85 to 82f75bb Compare November 8, 2017 19:45

rbuckton reviewed Nov 8, 2017

View reviewed changes

changed types of callbacks param: array

7a39d79

rbuckton requested changes Nov 9, 2017

View reviewed changes

typescript-bot closed this Jun 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactored typed arrays #18559

Refactored typed arrays #18559

NaridaL commented Sep 18, 2017

NaridaL commented Oct 17, 2017

mhegazy commented Nov 8, 2017

mhegazy commented Nov 8, 2017

NaridaL commented Nov 8, 2017 •

edited

Loading

NaridaL commented Nov 8, 2017

rbuckton Nov 8, 2017

NaridaL Nov 9, 2017

NaridaL Nov 9, 2017

mhegazy Nov 9, 2017

mhegazy Nov 9, 2017 •

edited

Loading

NaridaL Nov 9, 2017

rbuckton Nov 9, 2017

rbuckton Nov 9, 2017

NaridaL Nov 9, 2017 •

edited

Loading

NaridaL Nov 10, 2017

rbuckton Nov 9, 2017

rbuckton Nov 9, 2017

rbuckton Nov 9, 2017

rbuckton Nov 9, 2017

rbuckton Nov 9, 2017

rbuckton Nov 9, 2017

rbuckton Nov 9, 2017

rbuckton Nov 9, 2017

rbuckton Nov 9, 2017

rbuckton Nov 9, 2017

rbuckton Nov 10, 2017

typescript-bot commented Jun 12, 2018

Refactored typed arrays #18559

Refactored typed arrays #18559

Conversation

NaridaL commented Sep 18, 2017

NaridaL commented Oct 17, 2017

mhegazy commented Nov 8, 2017

mhegazy commented Nov 8, 2017

NaridaL commented Nov 8, 2017 • edited Loading

NaridaL commented Nov 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhegazy Nov 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NaridaL Nov 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

typescript-bot commented Jun 12, 2018

NaridaL commented Nov 8, 2017 •

edited

Loading

mhegazy Nov 9, 2017 •

edited

Loading

NaridaL Nov 9, 2017 •

edited

Loading