Do not await iterated value in for-await-of #24474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
May 29, 2018
ajafff
reviewed
Jun 1, 2018
| case 0: return { value: 1, done: false }; | ||
| case 1: return { value: Promise.resolve(2), done: false }; | ||
| case 2: return { value: new Promise<number>(resolve => setTimeout(resolve, 100, 3)), done: false }; | ||
| default: return { value: undefined: done: true }; |
There was a problem hiding this comment.
there is a typo on this line: undefined: should be undefined,
Same in all other test cases below
ajafff
added a commit
to ajafff/TypeScript
that referenced
this pull request
Jun 1, 2018
|
@mhegazy do you want this ported to |
|
yes please. |
rbuckton
pushed a commit
that referenced
this pull request
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change more closely aligns with the specified
for-await-ofsemantics, per 13.7.5.13, step 6.d-6.h. At no time during those steps is there an Await for nextValue.Fixes #21115