Decorator type metadata #2589
Merged
Decorator type metadata #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate functions due to merge conflict
…te and __metadata
| // | ||
| function emitDecoratorArray(decorators: NodeArray<Decorator>, writeComma: boolean, prefix?: string, postfix?: string): boolean { | ||
| if (decorators) { | ||
| let decoratorCount = decorators ? decorators.length : 0; |
There was a problem hiding this comment.
you already check for decorators is truthy.
| function checkParameterTypeAnnotationsAsExpressions(node: FunctionLikeDeclaration) { | ||
| // ensure all type annotations with a value declaration are checked as an expression | ||
| if (node) { | ||
| forEach(node.parameters, checkTypeAnnotationAsExpression); |
There was a problem hiding this comment.
this will stop with the first checkTypeAnnotationAsExpression that returns something 'truthy'. Is that what you wanted?
There was a problem hiding this comment.
checkTypeAnnotationAsExpression returns undefined, so generally this is fine. I have been periodically migrating these to for..of since its available in the compiler now, though it wasn't when this was originally written.
| for (var i = 0; i < parameterCount; i++) { | ||
| if (parameters[i].dotDotDotToken) { | ||
| var parameterType = parameters[i].type; | ||
| if (parameterType.kind === SyntaxKind.ArrayType) { |
There was a problem hiding this comment.
So we're doing this stuff syntactically only? Is that ok? Should we consider using the type information isntead?
rbuckton
added a commit
that referenced
this pull request
Apr 6, 2015
Experimental support for decorator type metadata. NOTE: Requires a polyfill for `Reflect.metadata` which has not yet been considered by TC39 for ES7.
Closed
14 tasks
This was referenced Sep 14, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2577
Adds support behind an experimental compiler option to emit design-time type metadata for decorated declarations in source.
__metadatahelper that depends on a polyfill for a proposedReflect.metadatadecorator.__paramhelper decorator used to apply parameter decorators after metadata is applied and before the method's decorators are run.__metadatafor class and member (property and method) decorators--emitDecoratorMetadata).A few notes on metadata: