🤖 User test baselines have changed #26156
Conversation
typescript-bot
force-pushed
the
user-update-20180704
branch
from
79cb356 to
15eab95
Compare
| Exit Code: 1 | ||
| Standard output: | ||
| node_modules/@types/react-native/index.d.ts(3895,26): error TS2693: 'setImmediate' only refers to a type, but is being used as a value here. | ||
| node_modules/@types/react-native/index.d.ts(3896,28): error TS2693: 'clearImmediate' only refers to a type, but is being used as a value here. |
There was a problem hiding this comment.
I still don't understand what is going on here.
There was a problem hiding this comment.
It seems like this is a good change since it turns out (thanks @weswigham!) that setImmediate/clearImmediate are IE/Edge/Node-only, and @types/node already includes them. @andy-ms, since you are doing a DefinitelyTyped sweep, do you know whether there are other packages besides react-native that need to be fixed?
| @@ -100,15 +100,15 @@ node_modules/lodash/_createFlow.js(56,13): error TS2454: Variable 'wrapper' is u | |||
| node_modules/lodash/_createFlow.js(57,13): error TS2454: Variable 'wrapper' is used before being assigned. | |||
| node_modules/lodash/_createFlow.js(57,21): error TS2339: Property 'thru' does not exist on type 'LodashWrapper'. | |||
| node_modules/lodash/_createFlow.js(65,24): error TS2339: Property 'plant' does not exist on type 'LodashWrapper'. | |||
| node_modules/lodash/_createHybrid.js(44,49): error TS2345: Argument of type 'string | Function' is not assignable to parameter of type 'Function'. | |||
| node_modules/lodash/_createHybrid.js(44,49): error TS2345: Argument of type 'TimerHandler' is not assignable to parameter of type 'Function'. | |||
There was a problem hiding this comment.
This alias is too general and should still be removed.
There was a problem hiding this comment.
Filed issue microsoft/TypeScript-DOM-lib-generator#559
| @@ -30,6 +30,7 @@ node_modules/npm/bin/npm-cli.js(132,17): error TS2339: Property 'config' does no | |||
| node_modules/npm/bin/npm-cli.js(134,17): error TS2339: Property 'config' does not exist on type 'typeof EventEmitter'. | |||
| node_modules/npm/bin/npm-cli.js(136,17): error TS2339: Property 'config' does not exist on type 'typeof EventEmitter'. | |||
| node_modules/npm/html/static/toc.js(3,40): error TS2531: Object is possibly 'null'. | |||
| node_modules/npm/html/static/toc.js(28,3): error TS2531: Object is possibly 'null'. | |||
There was a problem hiding this comment.
document.body: HTMLElement | null. Was it just HTMLElement before?
There was a problem hiding this comment.
After discussion with @weswigham and @rbuckton, we are pretty sure that this should still be HTMLElement. HTMLElement | nullis even more pedantic than making array indexing nullable. I'll file an issue on TSJS-libgenerator to track this fix.
@andy-ms once that fix is in, all the changes you had to make to DefinitelyTyped will be obsolete, sorry. :(
There was a problem hiding this comment.
Filed issue microsoft/TypeScript-DOM-lib-generator#558
|
OK, now that we have some issues to track follow-up, we can go ahead and merge this change. |
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @mhegazy