-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export getOutputJavaScriptFileName
from tsbuild
#26421
Conversation
0429bce
to
d85bf5a
Compare
Interesting that when I first opened this PR, it generated baselines in |
tsbuild API is internal right now and we would want to make sure to expose it right way after reworking on it. |
It no longer affects the API baselines because the entire |
👍🏽 Makes sense. In regard to the conversation in TypeStrong/ts-loader#815
Does that still stand with all the tsbuild stuff being marked internal? Other tsbuild functions are still exported, right? (Some of the others may be needed for the proposed second phase of ts-loader support, building upstream projects.) On the other hand, if all these APIs are totally internal and subject to change in patch releases, that makes them a bit hard to rely on in a package like ts-loader. @johnnyreilly thoughts on this? |
I'd much rather rely on TypeScript APIs than duplicate logic in ts-loader if possible. That said, we'll try and be pragmatic; if it's a simple function that's unlikely to change then it's not the end of the world if we duplicate. But that's very much second preference. |
We need to make a decision for ts-loader (TypeStrong/ts-loader#815) in the next couple days, so any update here from the team would be greatly appreciated. Thanks! |
We are still working on api to use project references and anything from tsbuild wont be available as api till that work is complete. |
Ok, thanks for the update. Feel free to close this if it doesn't make sense. |
Fixes #26410
Waiting to hear:
getOutputDeclarationFileName
for symmetry? What aboutgetOutputFileNames
?tsbuild.ts
still the right place for this now that it's being exported, should we add JSDoc comments to it (some exported functions have it, others don't)?