-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dom related reference files according to new IE spec #2645
Conversation
Hi @zhengbli, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Have we run this change against our real world code suites? We need to make sure changing the order of overloads doesn't break anything. |
There are indeed a bunch of breaking changes that cause 57 rwc tests to fail. And the reasons of failure are documented at: http://1drv.ms/1DFuYE7. Should the rwc tests be changed before merging? Also, what do you mean by "the order of overloads"? |
@zhengbli can you list the issues that will be fixed by this change as well. |
looking at this diff is hard. can we sort the declarations in some order to make the diff more useful |
also i do not think you need extensions.d.ts anymore. i could be wrong though. We have added them as some types in dom.generated.d.ts depended on them. if they are not used we should remove them and let es6.lib.d.ts be the only definition of these types. |
Issues that would be fixed: |
… UpdateDomRefFiles
That might need a new PR, or a force push on this branch, but it would be nice if we can get in the change to dom.generated.d.ts to sort it using the old script. Then add a commit with your change. this way we can look at the diff of the two commits and see the actual change. |
The IE team started to issue new specs in the format of XML files instead of webidl files for upcoming API changes. The new dom.generated.d.ts and webworker.d.ts are generated from the new XML specs to be consistent with IE Dom API changes.