#17542 enabling forceConsistentCasingInFileNames by default #27464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is now on by default. See microsoft#17542
This implements microsoft#17542 enable forceConsistentCasingInFileNames by default which fixes cross-platform compatability issues due to typescript not reporting different cases as an error in windows. Making change in right repo & branch this time >_<
|
|
RyanCavanaugh
requested changes
Jan 24, 2019
| @@ -588,23 +588,23 @@ export = C; | |||
| "/a/b/c.ts": `/// <reference path="D.ts"/>`, | |||
| "/a/b/d.ts": "var x" | |||
| }); | |||
| test(files, { module: ModuleKind.AMD, forceConsistentCasingInFileNames: true }, "/a/b", /*useCaseSensitiveFileNames*/ false, ["c.ts", "d.ts"], [1149]); | |||
There was a problem hiding this comment.
In addition to this, we should have test cases when forceConsistentCasingInFileNames is set to false now that its not default.
options.forceConsistentCasingInFileNames can't be null here
sheetalkamat
requested changes
Jan 25, 2019
There was a problem hiding this comment.
Given that both versions of each test behave similarly (with forceConsistentCasingInFileNames set to true and without forceConsistentCasingInFileNames value in compiler options) we need third equivalent of all test cases with forceConsistentCasingInFileNames set to false.
|
Sorry, the comments in the suggestion review didn't get properly copied to the issue. Please see the issue for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #17542 enable forceConsistentCasingInFileNames by default which fixes cross-platform compatability issues due to typescript not reporting different cases as an error in windows.
This is my first time modifying the typescript sourcecode, so hopefully I made the change in the right spot. I thought the PR would be a simple false -> true change in a config but apparently there's no central file for compiler option defaults.
In addition to this change the documentation at https://www.typescriptlang.org/docs/handbook/compiler-options.html would need to be updated.