Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic object rest variables and parameters #28312

Merged
merged 14 commits into from
Nov 6, 2018
Merged

Generic object rest variables and parameters #28312

merged 14 commits into from
Nov 6, 2018

Commits on Nov 1, 2018

  1. Add Rest<T, K> type to lib.d.ts

    @ahejlsberg
    ahejlsberg committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    f555261 View commit details
    Browse the repository at this point in the history

  2. Use Rest<T, K> for rest properties in object destructuring

    @ahejlsberg
    ahejlsberg committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    6f8959b View commit details
    Browse the repository at this point in the history

  3. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    18f80b8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into genericRest 

    # Conflicts:
#	tests/baselines/reference/objectRest.errors.txt
#	tests/baselines/reference/objectRest.types
    @ahejlsberg
    ahejlsberg committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    b0a5337 View commit details
    Browse the repository at this point in the history

  5. Define Rest<T, K> as Pick<T, Exclude<keyof T, K>> to ensure it is hom… 

    …omorphic
    @ahejlsberg
    ahejlsberg committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    0b194a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2018

  1. Only create Rest<T, K> types when object and/or key type is generic

    @ahejlsberg
    ahejlsberg committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    396642d View commit details
    Browse the repository at this point in the history

  2. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    f558059 View commit details
    Browse the repository at this point in the history

  3. Remove Rest<T, K> and use Pick<T, Exclude<keyof T, K>> instead

    @ahejlsberg
    ahejlsberg committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    9fd7d0a View commit details
    Browse the repository at this point in the history

  4. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    9daf69d View commit details
    Browse the repository at this point in the history

  5. Ensure '{ [key]: x } = obj' for generic key is the same as 'x = obj[k… 

    …ey]'
    @ahejlsberg
    ahejlsberg committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    abebf15 View commit details
    Browse the repository at this point in the history

  6. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    bcc1d2a View commit details
    Browse the repository at this point in the history

  7. Add tests

    @ahejlsberg
    ahejlsberg committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    48c0aed View commit details
    Browse the repository at this point in the history

  8. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    00c5071 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. Merge branch 'master' into genericRest 

    # Conflicts:
#	src/compiler/checker.ts
    @ahejlsberg
    ahejlsberg committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    f9dd445 View commit details
    Browse the repository at this point in the history