Fix gulp builds not building some targets, use LKG by default #29447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
reviewed
Jan 17, 2019
|
|
||
| const watchPatterns = [ | ||
| "src/tsconfig-base.json", |
There was a problem hiding this comment.
Shouldn't these also be watching the test case directories for actual test changes?
There was a problem hiding this comment.
There was a problem hiding this comment.
Seems like this might be fixed in gulp 4? Minimally it uses a different watching backend.
There was a problem hiding this comment.
Gulp4 requires a major overhaul of the build process.
|
@weswigham: any other comments? |
weswigham
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing
gulp defaultin a clean (or mostly clean) repo, the gulp build would sometimes exit prematurely without any indication. This was due to parallel executions of the compilation graph resulting in gulp task status being overwritten.For now, the simple fix is to serialize access to the compilation graph so that tasks are always run cleanly.
This also changes the default behavior of the gulp builds to using the LKG compiler. To build the compiler using the built compiler, use
gulp --no-lkg.