Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand "set your lib" suggestions to other commonly used ES2015 declarations #29766

Conversation

DanielRosenwasser
Copy link
Member

Fixes #29751

@DanielRosenwasser DanielRosenwasser changed the title Use all the es2015 names wesley what is so hard about that Expand "set your lib" suggestions to other commonly used ES2015 declarations Feb 6, 2019
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, that branch name.

@DanielRosenwasser
Copy link
Member Author

You know I only did it to make you laugh. ❤️

@DanielRosenwasser DanielRosenwasser merged commit 4505eea into master Feb 6, 2019
@DanielRosenwasser DanielRosenwasser deleted the USE-ALL-THE-ES2015-NAMES-WESLEY-WHAT-IS-SO-HARD-ABOUT-THAT branch February 6, 2019 02:31
@ericanderson
Copy link
Contributor

This branch name is amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants