Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 User test baselines have changed #30168

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

typescript-bot
Copy link
Collaborator

Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @weswigham @sandersn @RyanCavanaugh

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m going to merge these updates, because fixing #30159 turned out to be non-trivial — I need to detect that a symbol will be aliased by module.exports= and create the type differently. It’s not clear that the fix won’t end up being too complex to be worthwhile.

In addition, the bluebird example will still be wrong after the bug fix. The usage of top level this is in a dist-file that tries to detect its environment and provide a consistent global object. But because it also references module.exports (it also tries to detect that), we think it is a module and treat top level this as a reference to the module. Real code would never export the module itself as an exported property, and that is not in fact what bluebird is trying to do.

@sandersn sandersn merged commit f776bea into microsoft:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants