Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update singleCompilation flag name to isolatedModules #3208

Merged
merged 2 commits into from
May 19, 2015

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented May 19, 2015

No description provided.

@paulvanbrenk
Copy link
Contributor

👍

@DanielRosenwasser
Copy link
Member

Are we sure we want isolatedModules and not isolatedModule?

@yuit
Copy link
Contributor

yuit commented May 19, 2015

lgtm. though agree with @DanielRosenwasser's question. I have slight preference with isolatedModule

mhegazy added a commit that referenced this pull request May 19, 2015
Update singleCompilation flag name to isolatedModules
@mhegazy mhegazy merged commit 5ea2cea into release-1.5 May 19, 2015
@mhegazy mhegazy deleted the updateSingleCompilationFlagName branch May 19, 2015 20:55
@mhegazy
Copy link
Contributor Author

mhegazy commented May 19, 2015

the idea is you would use this with in a normal compilation, with multiple files, to ensure you can do the compile them in isolation later, hence the "s".

ivogabe added a commit to ivogabe/gulp-typescript that referenced this pull request May 21, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants