Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retarget to es6 and fix the resulting bugs #32221

Merged
merged 4 commits into from
Aug 1, 2019
Merged

Retarget to es6 and fix the resulting bugs #32221

merged 4 commits into from
Aug 1, 2019

Conversation

weswigham
Copy link
Member

Fixes #32206

We had a couple TDZ bugs and a case where we for ..in'd over the keys of a class instance to make a wrapper for it (which doesn't work on real es6 classes since the methods are non-enumerable and on the prototype).

We don't need to retarget to es6, per sey, but it does make debugging certain things a little bit nicer - notably classes and generators, and we don't have much keeping us targeting es5, since every runtime we test on is es6+.

@weswigham
Copy link
Member Author

@typescript-bot perf test this - gotta see if/how re-targeting affects perf

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 2, 2019 •
edited
Loading

Heya @weswigham, I've started to run the perf test suite on this PR at 086e2c7. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..32221

Metric master 32221 Delta Best Worst
Angular - node (v12.1.0, x64)
Memory used 315,988k (± 0.02%) 316,688k (± 0.02%) +700k (+ 0.22%) 316,568k 316,885k
Parse Time 1.38s (± 0.56%) 1.44s (± 0.46%) +0.06s (+ 4.27%) 1.43s 1.45s
Bind Time 0.73s (± 0.61%) 0.75s (± 0.67%) +0.01s (+ 1.78%) 0.73s 0.75s
Check Time 4.12s (± 0.46%) 4.25s (± 0.56%) +0.13s (+ 3.18%) 4.20s 4.31s
Emit Time 5.20s (± 0.72%) 5.34s (± 1.01%) +0.14s (+ 2.75%) 5.24s 5.49s
Total Time 11.44s (± 0.37%) 11.78s (± 0.62%) +0.34s (+ 3.01%) 11.66s 11.98s
Monaco - node (v12.1.0, x64)
Memory used 345,623k (± 0.01%) 345,852k (± 0.01%) +229k (+ 0.07%) 345,770k 345,951k
Parse Time 1.18s (± 0.62%) 1.24s (± 0.63%) +0.06s (+ 5.18%) 1.22s 1.26s
Bind Time 0.67s (± 0.99%) 0.69s (± 0.75%) +0.02s (+ 2.67%) 0.68s 0.70s
Check Time 4.22s (± 0.52%) 4.28s (± 0.37%) +0.06s (+ 1.49%) 4.24s 4.32s
Emit Time 2.85s (± 0.53%) 2.90s (± 0.47%) +0.05s (+ 1.83%) 2.88s 2.94s
Total Time 8.92s (± 0.38%) 9.11s (± 0.27%) +0.19s (+ 2.19%) 9.06s 9.16s
TFS - node (v12.1.0, x64)
Memory used 301,147k (± 0.01%) 301,355k (± 0.01%) +208k (+ 0.07%) 301,260k 301,441k
Parse Time 0.90s (± 0.49%) 0.95s (± 0.61%) +0.05s (+ 5.32%) 0.94s 0.96s
Bind Time 0.62s (± 1.13%) 0.64s (± 0.77%) +0.01s (+ 2.42%) 0.63s 0.65s
Check Time 3.77s (± 0.47%) 3.88s (± 0.53%) +0.10s (+ 2.73%) 3.85s 3.95s
Emit Time 2.94s (± 1.33%) 3.00s (± 1.10%) +0.06s (+ 2.08%) 2.95s 3.08s
Total Time 8.23s (± 0.63%) 8.46s (± 0.43%) +0.23s (+ 2.77%) 8.40s 8.55s
Angular - node (v8.9.0, x64)
Memory used 334,325k (± 0.02%) 334,894k (± 0.02%) +569k (+ 0.17%) 334,779k 335,033k
Parse Time 1.78s (± 0.41%) 1.90s (± 0.55%) +0.12s (+ 6.51%) 1.88s 1.92s
Bind Time 0.79s (± 0.98%) 0.81s (± 1.00%) +0.02s (+ 2.78%) 0.80s 0.84s
Check Time 4.87s (± 1.54%) 4.93s (± 0.44%) +0.06s (+ 1.25%) 4.89s 4.98s
Emit Time 5.97s (± 2.23%) 5.99s (± 0.56%) +0.01s (+ 0.23%) 5.91s 6.05s
Total Time 13.41s (± 0.77%) 13.63s (± 0.25%) +0.21s (+ 1.60%) 13.56s 13.71s
Monaco - node (v8.9.0, x64)
Memory used 362,806k (± 0.02%) 363,445k (± 0.02%) +640k (+ 0.18%) 363,316k 363,576k
Parse Time 1.44s (± 0.56%) 1.52s (± 0.33%) +0.09s (+ 6.05%) 1.52s 1.54s
Bind Time 0.90s (± 1.84%) 0.91s (± 0.65%) +0.01s (+ 1.11%) 0.90s 0.93s
Check Time 5.08s (± 1.90%) 4.65s (± 0.62%) -0.43s (- 8.41%) 4.56s 4.70s
Emit Time 3.27s (± 6.40%) 3.22s (± 0.48%) -0.05s (- 1.53%) 3.19s 3.27s
Total Time 10.69s (± 1.31%) 10.31s (± 0.39%) -0.38s (- 3.55%) 10.20s 10.42s
TFS - node (v8.9.0, x64)
Memory used 316,831k (± 0.01%) 317,207k (± 0.02%) +376k (+ 0.12%) 317,089k 317,347k
Parse Time 1.13s (± 0.55%) 1.21s (± 0.68%) +0.08s (+ 7.34%) 1.20s 1.24s
Bind Time 0.66s (± 0.55%) 0.68s (± 0.59%) +0.01s (+ 2.26%) 0.67s 0.69s
Check Time 4.37s (± 0.67%) 4.48s (± 1.28%) +0.11s (+ 2.50%) 4.41s 4.68s
Emit Time 3.20s (± 0.67%) 3.02s (± 0.74%) -0.18s (- 5.63%) 2.94s 3.06s
Total Time 9.36s (± 0.37%) 9.38s (± 0.92%) +0.02s (+ 0.26%) 9.23s 9.68s
Angular - node (v8.9.0, x86)
Memory used 189,329k (± 0.02%) 189,855k (± 0.02%) +526k (+ 0.28%) 189,763k 189,960k
Parse Time 1.73s (± 0.43%) 1.88s (± 0.67%) +0.15s (+ 8.63%) 1.85s 1.91s
Bind Time 0.93s (± 0.81%) 0.95s (± 0.47%) +0.02s (+ 1.93%) 0.94s 0.96s
Check Time 4.50s (± 0.68%) 4.48s (± 0.64%) -0.02s (- 0.33%) 4.42s 4.53s
Emit Time 5.75s (± 1.02%) 5.60s (± 0.68%) -0.16s (- 2.73%) 5.51s 5.66s
Total Time 12.90s (± 0.62%) 12.91s (± 0.35%) +0.01s (+ 0.04%) 12.81s 13.00s
Monaco - node (v8.9.0, x86)
Memory used 202,458k (± 0.02%) 202,931k (± 0.02%) +473k (+ 0.23%) 202,828k 203,032k
Parse Time 1.49s (± 0.52%) 1.62s (± 0.72%) +0.13s (+ 8.53%) 1.59s 1.65s
Bind Time 0.72s (± 1.25%) 0.74s (± 1.00%) +0.02s (+ 3.50%) 0.73s 0.76s
Check Time 4.79s (± 0.58%) 4.66s (± 0.50%) -0.13s (- 2.74%) 4.60s 4.70s
Emit Time 3.17s (± 0.50%) 3.10s (± 0.60%) -0.07s (- 2.30%) 3.05s 3.13s
Total Time 10.16s (± 0.36%) 10.12s (± 0.43%) -0.05s (- 0.47%) 9.99s 10.21s
TFS - node (v8.9.0, x86)
Memory used 177,824k (± 0.01%) 178,080k (± 0.02%) +256k (+ 0.14%) 177,999k 178,145k
Parse Time 1.19s (± 0.86%) 1.28s (± 0.52%) +0.09s (+ 7.72%) 1.26s 1.29s
Bind Time 0.63s (± 1.03%) 0.66s (± 0.61%) +0.03s (+ 5.25%) 0.65s 0.67s
Check Time 4.19s (± 1.06%) 4.28s (± 0.60%) +0.09s (+ 2.05%) 4.23s 4.36s
Emit Time 2.86s (± 1.00%) 2.89s (± 0.72%) +0.03s (+ 1.08%) 2.85s 2.95s
Total Time 8.88s (± 0.76%) 9.12s (± 0.31%) +0.25s (+ 2.77%) 9.07s 9.21s
Angular - node (v9.0.0, x64)
Memory used 333,981k (± 0.02%) 334,443k (± 0.01%) +463k (+ 0.14%) 334,311k 334,527k
Parse Time 1.62s (± 0.54%) 1.72s (± 0.29%) +0.11s (+ 6.55%) 1.71s 1.73s
Bind Time 0.74s (± 0.90%) 0.76s (± 0.53%) +0.02s (+ 2.15%) 0.75s 0.77s
Check Time 4.48s (± 0.42%) 4.46s (± 0.36%) -0.02s (- 0.40%) 4.42s 4.49s
Emit Time 5.85s (± 1.78%) 5.99s (± 1.09%) +0.14s (+ 2.44%) 5.82s 6.12s
Total Time 12.69s (± 0.90%) 12.94s (± 0.49%) +0.25s (+ 1.96%) 12.77s 13.07s
Monaco - node (v9.0.0, x64)
Memory used 362,534k (± 0.04%) 362,975k (± 0.01%) +441k (+ 0.12%) 362,867k 363,099k
Parse Time 1.28s (± 0.31%) 1.37s (± 0.85%) +0.09s (+ 7.19%) 1.34s 1.40s
Bind Time 0.85s (± 0.40%) 0.85s (± 1.03%) +0.01s (+ 0.71%) 0.83s 0.87s
Check Time 4.83s (± 0.51%) 4.63s (± 0.41%) -0.20s (- 4.10%) 4.59s 4.66s
Emit Time 3.36s (± 0.41%) 3.16s (± 2.67%) -0.20s (- 5.96%) 2.92s 3.23s
Total Time 10.31s (± 0.35%) 10.01s (± 1.01%) -0.30s (- 2.92%) 9.70s 10.12s
TFS - node (v9.0.0, x64)
Memory used 316,566k (± 0.02%) 316,751k (± 0.01%) +185k (+ 0.06%) 316,685k 316,816k
Parse Time 1.01s (± 0.40%) 1.06s (± 0.77%) +0.05s (+ 5.35%) 1.04s 1.08s
Bind Time 0.61s (± 0.56%) 0.63s (± 0.71%) +0.01s (+ 2.45%) 0.62s 0.64s
Check Time 4.30s (± 1.42%) 4.56s (± 1.75%) +0.26s (+ 5.97%) 4.35s 4.68s
Emit Time 3.17s (± 2.21%) 3.03s (± 2.23%) -0.14s (- 4.30%) 2.96s 3.22s
Total Time 9.09s (± 0.37%) 9.28s (± 0.36%) +0.19s (+ 2.09%) 9.22s 9.38s
Angular - node (v9.0.0, x86)
Memory used 189,528k (± 0.03%) 189,852k (± 0.02%) +324k (+ 0.17%) 189,788k 189,996k
Parse Time 1.54s (± 0.76%) 1.67s (± 0.49%) +0.13s (+ 8.63%) 1.66s 1.70s
Bind Time 0.87s (± 0.68%) 0.89s (± 0.76%) +0.02s (+ 2.29%) 0.88s 0.91s
Check Time 4.18s (± 0.52%) 4.23s (± 0.54%) +0.05s (+ 1.24%) 4.17s 4.29s
Emit Time 5.46s (± 1.00%) 5.44s (± 0.41%) -0.02s (- 0.35%) 5.39s 5.50s
Total Time 12.06s (± 0.58%) 12.24s (± 0.31%) +0.18s (+ 1.51%) 12.17s 12.31s
Monaco - node (v9.0.0, x86)
Memory used 202,461k (± 0.01%) 202,716k (± 0.01%) +255k (+ 0.13%) 202,623k 202,772k
Parse Time 1.31s (± 0.63%) 1.42s (± 0.35%) +0.11s (+ 8.42%) 1.41s 1.43s
Bind Time 0.64s (± 0.74%) 0.67s (± 0.66%) +0.03s (+ 4.51%) 0.66s 0.68s
Check Time 4.62s (± 0.36%) 4.57s (± 0.57%) -0.05s (- 1.13%) 4.53s 4.63s
Emit Time 3.10s (± 0.57%) 3.05s (± 0.62%) -0.05s (- 1.65%) 3.00s 3.10s
Total Time 9.67s (± 0.27%) 9.70s (± 0.31%) +0.03s (+ 0.33%) 9.63s 9.77s
TFS - node (v9.0.0, x86)
Memory used 177,843k (± 0.02%) 177,939k (± 0.02%) +97k (+ 0.05%) 177,869k 178,012k
Parse Time 1.02s (± 0.67%) 1.11s (± 0.95%) +0.09s (+ 8.68%) 1.10s 1.14s
Bind Time 0.57s (± 0.59%) 0.59s (± 0.62%) +0.02s (+ 3.84%) 0.59s 0.60s
Check Time 4.03s (± 0.78%) 4.13s (± 0.43%) +0.10s (+ 2.48%) 4.10s 4.17s
Emit Time 2.77s (± 0.51%) 2.84s (± 1.12%) +0.07s (+ 2.45%) 2.81s 2.96s
Total Time 8.41s (± 0.38%) 8.68s (± 0.48%) +0.28s (+ 3.32%) 8.61s 8.83s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-142-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
  • node (v9.0.0, x64)
  • node (v9.0.0, x86)
Scenarios
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Angular - node (v9.0.0, x64)
  • Angular - node (v9.0.0, x86)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • Monaco - node (v9.0.0, x64)
  • Monaco - node (v9.0.0, x86)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • TFS - node (v9.0.0, x64)
  • TFS - node (v9.0.0, x86)
Benchmark Name Iterations
Current 32221 10
Baseline master 10

@weswigham
Copy link
Member Author

Yick - there's substantial improvements in one or two places on one or two versions, but generally across the board worseness, especially on node 12. 🤷‍♂ Guess I'll just change the target for debugging locally then.

@weswigham
Copy link
Member Author

@typescript-bot perf test this again, just to validate that those performance regressions aren't just because of the correctness changes

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 2, 2019 •
edited
Loading

Heya @weswigham, I've started to run the perf test suite on this PR at b982747. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..32221

Metric master 32221 Delta Best Worst
Angular - node (v12.1.0, x64)
Memory used 315,988k (± 0.02%) 316,705k (± 0.02%) +717k (+ 0.23%) 316,605k 316,832k
Parse Time 1.38s (± 0.56%) 1.44s (± 0.77%) +0.06s (+ 4.49%) 1.42s 1.47s
Bind Time 0.73s (± 0.61%) 0.74s (± 0.67%) +0.01s (+ 1.78%) 0.74s 0.76s
Check Time 4.12s (± 0.46%) 4.26s (± 0.38%) +0.14s (+ 3.47%) 4.23s 4.30s
Emit Time 5.20s (± 0.72%) 5.33s (± 0.36%) +0.13s (+ 2.40%) 5.29s 5.39s
Total Time 11.44s (± 0.37%) 11.78s (± 0.28%) +0.34s (+ 3.00%) 11.72s 11.85s
Monaco - node (v12.1.0, x64)
Memory used 345,623k (± 0.01%) 345,837k (± 0.02%) +214k (+ 0.06%) 345,678k 345,936k
Parse Time 1.18s (± 0.62%) 1.25s (± 1.01%) +0.07s (+ 5.69%) 1.22s 1.28s
Bind Time 0.67s (± 0.99%) 0.69s (± 1.18%) +0.02s (+ 2.97%) 0.68s 0.72s
Check Time 4.22s (± 0.52%) 4.29s (± 0.48%) +0.08s (+ 1.78%) 4.25s 4.33s
Emit Time 2.85s (± 0.53%) 2.91s (± 0.40%) +0.06s (+ 2.07%) 2.89s 2.94s
Total Time 8.92s (± 0.38%) 9.14s (± 0.30%) +0.22s (+ 2.46%) 9.09s 9.21s
TFS - node (v12.1.0, x64)
Memory used 301,147k (± 0.01%) 301,395k (± 0.01%) +248k (+ 0.08%) 301,308k 301,511k
Parse Time 0.90s (± 0.49%) 0.95s (± 0.79%) +0.04s (+ 4.99%) 0.93s 0.96s
Bind Time 0.62s (± 1.13%) 0.64s (± 0.87%) +0.02s (+ 2.74%) 0.63s 0.65s
Check Time 3.77s (± 0.47%) 3.88s (± 0.47%) +0.11s (+ 2.86%) 3.84s 3.92s
Emit Time 2.94s (± 1.33%) 2.99s (± 0.43%) +0.05s (+ 1.67%) 2.95s 3.02s
Total Time 8.23s (± 0.63%) 8.45s (± 0.33%) +0.22s (+ 2.70%) 8.39s 8.51s
Angular - node (v8.9.0, x64)
Memory used 334,325k (± 0.02%) 334,883k (± 0.01%) +558k (+ 0.17%) 334,799k 334,965k
Parse Time 1.78s (± 0.41%) 1.89s (± 0.27%) +0.11s (+ 6.12%) 1.88s 1.90s
Bind Time 0.79s (± 0.98%) 0.81s (± 0.45%) +0.02s (+ 2.91%) 0.81s 0.82s
Check Time 4.87s (± 1.54%) 4.92s (± 0.38%) +0.05s (+ 0.94%) 4.88s 4.95s
Emit Time 5.97s (± 2.23%) 6.00s (± 0.86%) +0.03s (+ 0.45%) 5.84s 6.07s
Total Time 13.41s (± 0.77%) 13.62s (± 0.50%) +0.21s (+ 1.53%) 13.40s 13.73s
Monaco - node (v8.9.0, x64)
Memory used 362,806k (± 0.02%) 363,383k (± 0.02%) +577k (+ 0.16%) 363,217k 363,548k
Parse Time 1.44s (± 0.56%) 1.52s (± 0.34%) +0.08s (+ 5.63%) 1.51s 1.53s
Bind Time 0.90s (± 1.84%) 0.92s (± 0.61%) +0.01s (+ 1.55%) 0.91s 0.93s
Check Time 5.08s (± 1.90%) 4.69s (± 0.65%) -0.39s (- 7.74%) 4.64s 4.78s
Emit Time 3.27s (± 6.40%) 3.21s (± 0.58%) -0.05s (- 1.68%) 3.16s 3.26s
Total Time 10.69s (± 1.31%) 10.33s (± 0.48%) -0.35s (- 3.28%) 10.22s 10.48s
TFS - node (v8.9.0, x64)
Memory used 316,831k (± 0.01%) 317,210k (± 0.02%) +379k (+ 0.12%) 317,080k 317,331k
Parse Time 1.13s (± 0.55%) 1.22s (± 0.60%) +0.09s (+ 7.69%) 1.20s 1.23s
Bind Time 0.66s (± 0.55%) 0.69s (± 0.87%) +0.02s (+ 3.31%) 0.68s 0.70s
Check Time 4.37s (± 0.67%) 4.53s (± 1.54%) +0.17s (+ 3.78%) 4.42s 4.71s
Emit Time 3.20s (± 0.67%) 3.02s (± 2.01%) -0.18s (- 5.47%) 2.96s 3.26s
Total Time 9.36s (± 0.37%) 9.46s (± 1.16%) +0.10s (+ 1.04%) 9.29s 9.73s
Angular - node (v8.9.0, x86)
Memory used 189,329k (± 0.02%) 189,877k (± 0.04%) +548k (+ 0.29%) 189,756k 190,054k
Parse Time 1.73s (± 0.43%) 1.88s (± 0.92%) +0.16s (+ 9.09%) 1.85s 1.93s
Bind Time 0.93s (± 0.81%) 0.95s (± 0.62%) +0.02s (+ 2.14%) 0.94s 0.97s
Check Time 4.50s (± 0.68%) 4.50s (± 0.76%) +0.00s (+ 0.09%) 4.42s 4.55s
Emit Time 5.75s (± 1.02%) 5.64s (± 0.46%) -0.12s (- 2.03%) 5.57s 5.71s
Total Time 12.90s (± 0.62%) 12.97s (± 0.41%) +0.07s (+ 0.53%) 12.86s 13.08s
Monaco - node (v8.9.0, x86)
Memory used 202,458k (± 0.02%) 202,913k (± 0.02%) +454k (+ 0.22%) 202,841k 203,024k
Parse Time 1.49s (± 0.52%) 1.62s (± 0.37%) +0.14s (+ 9.07%) 1.61s 1.64s
Bind Time 0.72s (± 1.25%) 0.74s (± 0.49%) +0.03s (+ 4.06%) 0.74s 0.75s
Check Time 4.79s (± 0.58%) 4.65s (± 0.26%) -0.13s (- 2.80%) 4.61s 4.67s
Emit Time 3.17s (± 0.50%) 3.11s (± 0.41%) -0.06s (- 2.02%) 3.08s 3.14s
Total Time 10.16s (± 0.36%) 10.13s (± 0.22%) -0.03s (- 0.30%) 10.07s 10.18s
TFS - node (v8.9.0, x86)
Memory used 177,824k (± 0.01%) 178,097k (± 0.01%) +273k (+ 0.15%) 178,047k 178,157k
Parse Time 1.19s (± 0.86%) 1.29s (± 0.65%) +0.09s (+ 7.89%) 1.26s 1.30s
Bind Time 0.63s (± 1.03%) 0.67s (± 1.22%) +0.04s (+ 6.21%) 0.65s 0.68s
Check Time 4.19s (± 1.06%) 4.29s (± 0.50%) +0.10s (+ 2.38%) 4.25s 4.33s
Emit Time 2.86s (± 1.00%) 2.89s (± 1.19%) +0.03s (+ 1.08%) 2.80s 2.95s
Total Time 8.88s (± 0.76%) 9.13s (± 0.57%) +0.26s (+ 2.93%) 8.98s 9.24s
Angular - node (v9.0.0, x64)
Memory used 333,981k (± 0.02%) 334,434k (± 0.02%) +453k (+ 0.14%) 334,350k 334,566k
Parse Time 1.62s (± 0.54%) 1.73s (± 0.37%) +0.11s (+ 6.80%) 1.72s 1.74s
Bind Time 0.74s (± 0.90%) 0.76s (± 0.89%) +0.02s (+ 2.83%) 0.75s 0.78s
Check Time 4.48s (± 0.42%) 4.49s (± 1.22%) +0.01s (+ 0.22%) 4.44s 4.70s
Emit Time 5.85s (± 1.78%) 6.01s (± 1.30%) +0.16s (+ 2.68%) 5.79s 6.16s
Total Time 12.69s (± 0.90%) 12.99s (± 0.61%) +0.30s (+ 2.34%) 12.73s 13.12s
Monaco - node (v9.0.0, x64)
Memory used 362,534k (± 0.04%) 362,961k (± 0.01%) +427k (+ 0.12%) 362,871k 363,055k
Parse Time 1.28s (± 0.31%) 1.38s (± 0.65%) +0.10s (+ 7.58%) 1.36s 1.40s
Bind Time 0.85s (± 0.40%) 0.86s (± 0.87%) +0.01s (+ 1.18%) 0.84s 0.87s
Check Time 4.83s (± 0.51%) 4.67s (± 0.42%) -0.17s (- 3.42%) 4.62s 4.71s
Emit Time 3.36s (± 0.41%) 3.15s (± 2.55%) -0.21s (- 6.29%) 2.92s 3.25s
Total Time 10.31s (± 0.35%) 10.04s (± 0.87%) -0.27s (- 2.61%) 9.82s 10.19s
TFS - node (v9.0.0, x64)
Memory used 316,566k (± 0.02%) 316,731k (± 0.01%) +165k (+ 0.05%) 316,667k 316,797k
Parse Time 1.01s (± 0.40%) 1.06s (± 0.55%) +0.05s (+ 5.35%) 1.05s 1.08s
Bind Time 0.61s (± 0.56%) 0.63s (± 0.47%) +0.02s (+ 3.10%) 0.63s 0.64s
Check Time 4.30s (± 1.42%) 4.55s (± 1.65%) +0.24s (+ 5.62%) 4.34s 4.67s
Emit Time 3.17s (± 2.21%) 3.01s (± 2.15%) -0.16s (- 4.96%) 2.94s 3.18s
Total Time 9.09s (± 0.37%) 9.25s (± 0.30%) +0.16s (+ 1.74%) 9.20s 9.32s
Angular - node (v9.0.0, x86)
Memory used 189,528k (± 0.03%) 189,904k (± 0.03%) +376k (+ 0.20%) 189,763k 190,034k
Parse Time 1.54s (± 0.76%) 1.68s (± 1.10%) +0.14s (+ 8.89%) 1.65s 1.74s
Bind Time 0.87s (± 0.68%) 0.89s (± 0.55%) +0.02s (+ 2.29%) 0.88s 0.90s
Check Time 4.18s (± 0.52%) 4.24s (± 0.63%) +0.07s (+ 1.63%) 4.18s 4.31s
Emit Time 5.46s (± 1.00%) 5.50s (± 0.69%) +0.04s (+ 0.75%) 5.40s 5.59s
Total Time 12.06s (± 0.58%) 12.32s (± 0.60%) +0.26s (+ 2.16%) 12.14s 12.51s
Monaco - node (v9.0.0, x86)
Memory used 202,461k (± 0.01%) 202,674k (± 0.02%) +213k (+ 0.11%) 202,581k 202,773k
Parse Time 1.31s (± 0.63%) 1.42s (± 0.42%) +0.11s (+ 8.42%) 1.40s 1.43s
Bind Time 0.64s (± 0.74%) 0.68s (± 0.89%) +0.03s (+ 4.98%) 0.66s 0.69s
Check Time 4.62s (± 0.36%) 4.56s (± 0.64%) -0.05s (- 1.15%) 4.51s 4.62s
Emit Time 3.10s (± 0.57%) 3.06s (± 0.64%) -0.03s (- 1.10%) 3.01s 3.10s
Total Time 9.67s (± 0.27%) 9.72s (± 0.47%) +0.05s (+ 0.52%) 9.62s 9.80s
TFS - node (v9.0.0, x86)
Memory used 177,843k (± 0.02%) 177,917k (± 0.02%) +74k (+ 0.04%) 177,834k 178,011k
Parse Time 1.02s (± 0.67%) 1.11s (± 1.00%) +0.09s (+ 8.78%) 1.09s 1.14s
Bind Time 0.57s (± 0.59%) 0.59s (± 0.57%) +0.02s (+ 3.49%) 0.59s 0.60s
Check Time 4.03s (± 0.78%) 4.13s (± 0.43%) +0.09s (+ 2.28%) 4.09s 4.16s
Emit Time 2.77s (± 0.51%) 2.85s (± 1.39%) +0.08s (+ 2.88%) 2.76s 2.97s
Total Time 8.41s (± 0.38%) 8.69s (± 0.51%) +0.28s (+ 3.34%) 8.56s 8.78s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-142-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
  • node (v9.0.0, x64)
  • node (v9.0.0, x86)
Scenarios
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Angular - node (v9.0.0, x64)
  • Angular - node (v9.0.0, x86)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • Monaco - node (v9.0.0, x64)
  • Monaco - node (v9.0.0, x86)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • TFS - node (v9.0.0, x64)
  • TFS - node (v9.0.0, x86)
Benchmark Name Iterations
Current 32221 10
Baseline master 10

@weswigham
Copy link
Member Author

uhhhh @rbuckton any idea why these changes would be affecting, eg, check time so much? There isn't a change to any object structures, nor any changes that should affect the checker here...

@weswigham weswigham mentioned this pull request Jul 29, 2019
Closed
@weswigham
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 1, 2019 •
edited
Loading

Heya @weswigham, I've started to run the perf test suite on this PR at 170aa05. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..32221

Metric master 32221 Delta Best Worst
Angular - node (v12.1.0, x64)
Memory used 325,295k (± 0.03%) 325,327k (± 0.02%) +32k (+ 0.01%) 325,139k 325,468k
Parse Time 1.45s (± 0.50%) 1.43s (± 0.57%) -0.02s (- 1.24%) 1.41s 1.45s
Bind Time 0.77s (± 0.87%) 0.76s (± 0.90%) -0.00s (- 0.26%) 0.75s 0.78s
Check Time 4.25s (± 0.43%) 4.23s (± 0.63%) -0.01s (- 0.33%) 4.18s 4.29s
Emit Time 5.33s (± 0.67%) 5.24s (± 0.56%) -0.09s (- 1.61%) 5.18s 5.31s
Total Time 11.78s (± 0.25%) 11.66s (± 0.45%) -0.12s (- 1.02%) 11.55s 11.78s
Monaco - node (v12.1.0, x64)
Memory used 345,773k (± 0.02%) 345,753k (± 0.01%) -20k (- 0.01%) 345,697k 345,845k
Parse Time 1.19s (± 0.52%) 1.18s (± 0.59%) -0.01s (- 0.84%) 1.16s 1.19s
Bind Time 0.68s (± 1.23%) 0.67s (± 0.71%) -0.00s (- 0.30%) 0.67s 0.69s
Check Time 4.28s (± 0.41%) 4.31s (± 0.30%) +0.03s (+ 0.58%) 4.28s 4.34s
Emit Time 2.86s (± 1.11%) 2.85s (± 0.56%) -0.01s (- 0.35%) 2.81s 2.89s
Total Time 9.01s (± 0.46%) 9.01s (± 0.21%) +0.00s (+ 0.00%) 8.95s 9.04s
TFS - node (v12.1.0, x64)
Memory used 301,268k (± 0.01%) 301,291k (± 0.02%) +24k (+ 0.01%) 301,154k 301,481k
Parse Time 0.92s (± 0.76%) 0.91s (± 0.82%) -0.01s (- 1.19%) 0.90s 0.93s
Bind Time 0.62s (± 0.76%) 0.62s (± 0.90%) -0.00s (- 0.32%) 0.61s 0.63s
Check Time 3.84s (± 0.22%) 3.83s (± 0.66%) -0.01s (- 0.21%) 3.79s 3.91s
Emit Time 2.98s (± 0.46%) 2.96s (± 0.78%) -0.02s (- 0.60%) 2.90s 3.02s
Total Time 8.36s (± 0.18%) 8.32s (± 0.56%) -0.04s (- 0.53%) 8.24s 8.45s
Angular - node (v8.9.0, x64)
Memory used 343,825k (± 0.01%) 343,904k (± 0.01%) +80k (+ 0.02%) 343,830k 344,021k
Parse Time 1.84s (± 0.58%) 1.83s (± 0.48%) -0.00s (- 0.16%) 1.82s 1.86s
Bind Time 0.82s (± 0.81%) 0.81s (± 0.68%) -0.01s (- 1.34%) 0.80s 0.82s
Check Time 5.10s (± 0.60%) 5.08s (± 0.50%) -0.02s (- 0.47%) 5.03s 5.13s
Emit Time 6.04s (± 0.97%) 6.01s (± 1.81%) -0.02s (- 0.36%) 5.65s 6.19s
Total Time 13.79s (± 0.36%) 13.73s (± 0.91%) -0.06s (- 0.44%) 13.34s 13.89s
Monaco - node (v8.9.0, x64)
Memory used 363,185k (± 0.01%) 363,156k (± 0.01%) -30k (- 0.01%) 362,964k 363,240k
Parse Time 1.44s (± 0.70%) 1.43s (± 0.52%) -0.01s (- 0.42%) 1.42s 1.45s
Bind Time 0.89s (± 1.33%) 0.88s (± 1.37%) -0.01s (- 0.90%) 0.87s 0.92s
Check Time 5.27s (± 1.73%) 5.25s (± 1.44%) -0.01s (- 0.27%) 5.03s 5.33s
Emit Time 3.03s (± 5.26%) 3.04s (± 4.67%) +0.02s (+ 0.50%) 2.91s 3.43s
Total Time 10.62s (± 0.84%) 10.61s (± 0.80%) -0.01s (- 0.13%) 10.51s 10.86s
TFS - node (v8.9.0, x64)
Memory used 317,126k (± 0.02%) 317,129k (± 0.02%) +3k (+ 0.00%) 317,036k 317,289k
Parse Time 1.14s (± 0.51%) 1.13s (± 0.66%) -0.01s (- 1.14%) 1.12s 1.15s
Bind Time 0.67s (± 0.51%) 0.67s (± 0.70%) +0.00s (+ 0.45%) 0.66s 0.68s
Check Time 4.50s (± 0.72%) 4.49s (± 0.65%) -0.02s (- 0.36%) 4.44s 4.56s
Emit Time 3.20s (± 2.36%) 3.23s (± 1.21%) +0.03s (+ 1.03%) 3.12s 3.30s
Total Time 9.51s (± 0.92%) 9.52s (± 0.46%) +0.01s (+ 0.06%) 9.45s 9.61s
Angular - node (v8.9.0, x86)
Memory used 194,757k (± 0.04%) 194,756k (± 0.03%) -1k (- 0.00%) 194,555k 194,885k
Parse Time 1.79s (± 0.61%) 1.77s (± 0.38%) -0.02s (- 1.06%) 1.76s 1.79s
Bind Time 0.96s (± 0.92%) 0.95s (± 0.47%) -0.01s (- 0.94%) 0.94s 0.96s
Check Time 4.63s (± 0.60%) 4.63s (± 0.56%) -0.00s (- 0.06%) 4.58s 4.69s
Emit Time 5.85s (± 1.01%) 5.84s (± 0.99%) -0.01s (- 0.14%) 5.65s 5.96s
Total Time 13.22s (± 0.25%) 13.19s (± 0.56%) -0.04s (- 0.26%) 12.96s 13.35s
Monaco - node (v8.9.0, x86)
Memory used 202,797k (± 0.02%) 202,813k (± 0.02%) +16k (+ 0.01%) 202,744k 202,942k
Parse Time 1.49s (± 0.74%) 1.49s (± 0.58%) -0.00s (- 0.13%) 1.47s 1.51s
Bind Time 0.71s (± 0.48%) 0.71s (± 0.51%) +0.00s (+ 0.14%) 0.71s 0.72s
Check Time 4.89s (± 0.44%) 4.91s (± 0.36%) +0.02s (+ 0.35%) 4.87s 4.95s
Emit Time 3.17s (± 0.51%) 3.17s (± 0.58%) +0.00s (+ 0.09%) 3.12s 3.20s
Total Time 10.26s (± 0.30%) 10.28s (± 0.19%) +0.02s (+ 0.15%) 10.24s 10.32s
TFS - node (v8.9.0, x86)
Memory used 178,150k (± 0.03%) 178,073k (± 0.02%) -76k (- 0.04%) 178,000k 178,149k
Parse Time 1.21s (± 0.69%) 1.19s (± 0.50%) -0.01s (- 0.91%) 1.18s 1.21s
Bind Time 0.63s (± 1.18%) 0.63s (± 0.71%) -0.01s (- 0.79%) 0.62s 0.64s
Check Time 4.34s (± 0.41%) 4.29s (± 0.77%) -0.04s (- 1.04%) 4.24s 4.35s
Emit Time 2.87s (± 0.68%) 2.85s (± 1.43%) -0.02s (- 0.59%) 2.79s 2.99s
Total Time 9.04s (± 0.37%) 8.96s (± 0.61%) -0.08s (- 0.84%) 8.85s 9.07s
Angular - node (v9.0.0, x64)
Memory used 343,512k (± 0.01%) 343,500k (± 0.02%) -12k (- 0.00%) 343,305k 343,637k
Parse Time 1.68s (± 0.62%) 1.68s (± 0.76%) +0.00s (+ 0.00%) 1.65s 1.71s
Bind Time 0.77s (± 1.20%) 0.77s (± 0.78%) -0.01s (- 0.78%) 0.75s 0.78s
Check Time 4.84s (± 0.61%) 4.83s (± 0.69%) -0.01s (- 0.29%) 4.75s 4.89s
Emit Time 5.72s (± 1.21%) 5.78s (± 0.69%) +0.06s (+ 1.00%) 5.70s 5.90s
Total Time 13.02s (± 0.71%) 13.05s (± 0.18%) +0.04s (+ 0.27%) 13.00s 13.11s
Monaco - node (v9.0.0, x64)
Memory used 363,005k (± 0.03%) 362,898k (± 0.03%) -107k (- 0.03%) 362,673k 363,168k
Parse Time 1.29s (± 0.75%) 1.29s (± 0.67%) -0.00s (- 0.08%) 1.27s 1.31s
Bind Time 0.86s (± 0.81%) 0.86s (± 0.68%) -0.00s (- 0.46%) 0.85s 0.87s
Check Time 4.92s (± 0.70%) 4.90s (± 0.55%) -0.02s (- 0.39%) 4.85s 4.98s
Emit Time 3.37s (± 0.69%) 3.36s (± 0.72%) -0.01s (- 0.21%) 3.31s 3.44s
Total Time 10.44s (± 0.60%) 10.41s (± 0.38%) -0.03s (- 0.27%) 10.35s 10.54s
TFS - node (v9.0.0, x64)
Memory used 316,899k (± 0.01%) 316,898k (± 0.01%) -1k (- 0.00%) 316,836k 317,008k
Parse Time 1.02s (± 0.65%) 1.02s (± 0.69%) -0.00s (- 0.20%) 1.00s 1.04s
Bind Time 0.62s (± 0.90%) 0.61s (± 0.60%) -0.00s (- 0.49%) 0.61s 0.62s
Check Time 4.41s (± 0.36%) 4.38s (± 0.40%) -0.04s (- 0.79%) 4.33s 4.41s
Emit Time 3.21s (± 0.74%) 3.21s (± 0.83%) +0.00s (+ 0.06%) 3.13s 3.26s
Total Time 9.26s (± 0.38%) 9.23s (± 0.40%) -0.04s (- 0.38%) 9.16s 9.32s
Angular - node (v9.0.0, x86)
Memory used 194,755k (± 0.02%) 194,757k (± 0.02%) +2k (+ 0.00%) 194,691k 194,847k
Parse Time 1.59s (± 0.69%) 1.60s (± 0.51%) +0.01s (+ 0.63%) 1.59s 1.62s
Bind Time 0.88s (± 0.51%) 0.89s (± 0.56%) +0.00s (+ 0.34%) 0.88s 0.90s
Check Time 4.28s (± 0.70%) 4.30s (± 0.69%) +0.02s (+ 0.56%) 4.25s 4.38s
Emit Time 5.47s (± 0.96%) 5.50s (± 0.44%) +0.03s (+ 0.48%) 5.45s 5.57s
Total Time 12.23s (± 0.67%) 12.29s (± 0.40%) +0.06s (+ 0.49%) 12.18s 12.38s
Monaco - node (v9.0.0, x86)
Memory used 202,812k (± 0.02%) 202,805k (± 0.02%) -7k (- 0.00%) 202,716k 202,913k
Parse Time 1.31s (± 0.68%) 1.31s (± 0.47%) -0.01s (- 0.38%) 1.30s 1.32s
Bind Time 0.64s (± 0.81%) 0.64s (± 0.56%) +0.00s (+ 0.47%) 0.64s 0.65s
Check Time 4.76s (± 1.90%) 4.71s (± 0.68%) -0.05s (- 0.95%) 4.62s 4.78s
Emit Time 3.06s (± 3.05%) 3.10s (± 0.63%) +0.04s (+ 1.27%) 3.07s 3.15s
Total Time 9.78s (± 0.47%) 9.77s (± 0.49%) -0.01s (- 0.07%) 9.63s 9.84s
TFS - node (v9.0.0, x86)
Memory used 178,153k (± 0.03%) 178,141k (± 0.01%) -12k (- 0.01%) 178,087k 178,193k
Parse Time 1.03s (± 0.85%) 1.02s (± 0.87%) -0.00s (- 0.49%) 1.01s 1.05s
Bind Time 0.57s (± 0.65%) 0.57s (± 0.52%) -0.00s (- 0.52%) 0.57s 0.58s
Check Time 4.16s (± 0.51%) 4.14s (± 0.57%) -0.02s (- 0.58%) 4.08s 4.18s
Emit Time 2.81s (± 1.34%) 2.77s (± 0.78%) -0.04s (- 1.49%) 2.72s 2.82s
Total Time 8.58s (± 0.59%) 8.50s (± 0.37%) -0.08s (- 0.89%) 8.42s 8.57s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-142-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
  • node (v9.0.0, x64)
  • node (v9.0.0, x86)
Scenarios
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Angular - node (v9.0.0, x64)
  • Angular - node (v9.0.0, x86)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • Monaco - node (v9.0.0, x64)
  • Monaco - node (v9.0.0, x86)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • TFS - node (v9.0.0, x64)
  • TFS - node (v9.0.0, x86)
Benchmark Name Iterations
Current 32221 10
Baseline master 10

@weswigham weswigham marked this pull request as ready for review August 1, 2019 21:23
@weswigham weswigham merged commit 00a75c4 into microsoft:master Aug 1, 2019
@weswigham weswigham deleted the es6-compliance-fixes branch August 1, 2019 21:24
@weswigham weswigham mentioned this pull request Aug 1, 2019
Closed
@kyle7zhang kyle7zhang mentioned this pull request Sep 24, 2019
Open
5 tasks
@jakebailey jakebailey mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests don't pass when TS is retargeted to es6 and moduleResolution: node
2 participants
@weswigham @typescript-bot