Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix longer type-only property access in non-emitting heritage clauses #37264

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Fix longer type-only property access in non-emitting heritage clauses #37264

merged 2 commits into from
Mar 9, 2020

Conversation

andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Mar 6, 2020 •
edited
Loading

Reported in of #36478 (comment) / #36496

Would like to get this in 3.8.4 if possible.

@andrewbranch
Copy link
Member Author

@typescript-bot cherry-pick this to release-3.8

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 9, 2020 •
edited
Loading

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-3.8 on this PR at eced0e0. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Mar 9, 2020
Merged
@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I've opened #37299 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 9, 2020
@andrewbranch @typescript-bot
Cherry-pick PR microsoft#37264 into release-3.8
bbf9115 
Component commits:
2669ce7 Fix longer type-only property access in non-emitting heritage clauses

eced0e0 Rename misnomer function
@andrewbranch andrewbranch merged commit bc0e5a2 into microsoft:master Mar 9, 2020
@andrewbranch andrewbranch deleted the bug/type-only-nested-namespace branch March 9, 2020 19:23
andrewbranch added a commit to typescript-bot/TypeScript that referenced this pull request Mar 9, 2020
@andrewbranch
Cherry-pick PR microsoft#37264 into release-3.8
c31d000 
Component commits:
2669ce7 Fix longer type-only property access in non-emitting heritage clauses

eced0e0 Rename misnomer function
andrewbranch added a commit that referenced this pull request Mar 9, 2020
@andrewbranch
🤖 Pick PR #37264 (Fix longer type-only property acces...) into releas…
650889e 
…e-3.8 (#37299)

* Cherry-pick PR #37264 into release-3.8

Component commits:
2669ce7 Fix longer type-only property access in non-emitting heritage clauses

eced0e0 Rename misnomer function

* Update unrelated baseline difference between master and 3.8

Co-authored-by: Andrew Branch <andrew@wheream.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@weswigham weswigham weswigham approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@andrewbranch andrewbranch

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewbranch @typescript-bot @DanielRosenwasser @weswigham @sheetalkamat