Fix tuple name homogeneity check #40118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
weswigham
added
the
For Milestone Bug
typescript-bot
removed
the
For Milestone Bug
|
what is the bug? From the tests it looks like the error didn't get reported on trailing (or final) named members in a previously-unnamed set of members. |
sandersn
approved these changes
Aug 19, 2020
|
@typescript-bot cherry-pick this into release-4.0 |
|
Heya @weswigham, I've started to run the task to cherry-pick this into |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 19, 2020
Component commits: e1f4f9c Fix tuple name homogeneity check
|
Hey @weswigham, I've opened #40134 for you. |
weswigham
added a commit
that referenced
this pull request
Aug 26, 2020
Component commits: e1f4f9c Fix tuple name homogeneity check Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug reported on the
babelrepo that I'd forgotten about until I read the release blog post.