Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially disable inference recursion tracking changes #40256

Closed
wants to merge 3 commits into from

Conversation

ahejlsberg
Copy link
Member

Experiment to see if partially disabling inference recursion tracking changes from recursive conditional types PR resolves the OOM we're seeing in the RWC test suites.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 26, 2020
@ahejlsberg
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 26, 2020

Heya @ahejlsberg, I've started to run the extended test suite on this PR at e9b8606. You can monitor the build here.

@ahejlsberg
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 26, 2020

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 0a506ac. You can monitor the build here.

@ahejlsberg
Copy link
Member Author

@weswigham Hmm, the RWC suites are failing even when I back out the changes that could potentially consume more memory by generating more work. I'm pretty sure there's nothing left in the recursive conditional types PR that could be the cause. Wonder if something else could be?

@ahejlsberg
Copy link
Member Author

@weswigham Also, here I ran the RWC tests before merging the PR and I'm pretty certain they passed (sadly that build has now gone away). The fact that none of this repros locally of course makes it extra hard to track down.

@weswigham
Copy link
Member

RWC should be fixed now~

@weswigham weswigham closed this Aug 27, 2020
@weswigham
Copy link
Member

No idea how a change merged on the timeline after your change was merged somehow affected your change's RWC run, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants