Add at method #40697

Kingwl · 2020-09-22T09:32:07Z

Fixes #40695

src/lib/esnext.array.d.ts

Kingwl · 2020-11-12T10:02:54Z

Up.

Jack-Works · 2020-11-12T11:18:34Z

This proposal has web combability problem so it's need to be renamed.

Kingwl · 2020-11-12T12:31:10Z

Well... tc39/proposal-relative-indexing-method#34

src/lib/esnext.array.d.ts

rbuckton · 2021-01-13T05:59:12Z

FYI, per the linked issue, item could not be used in ECMAScript due to web compatibility issues. See #40695 (comment)

typescript-bot · 2021-06-09T04:03:20Z

The TypeScript team hasn't accepted the linked issue #40695. If you can get it accepted, this PR will have a better chance of being reviewed.

src/lib/esnext.string.d.ts

src/compiler/commandLineParser.ts

src/lib/esnext.array.d.ts

Kingwl · 2021-06-09T04:09:32Z

src/testRunner/unittests/config/convertCompilerOptionsFromJson.ts

@@ -295,7 +295,11 @@ namespace ts {
                        file: undefined,
                        start: 0,
                        length: 0,
-                        messageText: "Argument for '--lib' option must be: 'es5', 'es6', 'es2015', 'es7', 'es2016', 'es2017', 'es2018', 'esnext', 'dom', 'dom.iterable', 'webworker', 'webworker.importscripts', 'scripthost', 'es2015.core', 'es2015.collection', 'es2015.generator', 'es2015.iterable', 'es2015.promise', 'es2015.proxy', 'es2015.reflect', 'es2015.symbol', 'es2015.symbol.wellknown', 'es2016.array.include', 'es2017.object', 'es2017.sharedmemory', 'es2017.string', 'es2017.intl', 'es2017.typedarrays', 'es2018.asynciterable', 'es2018.intl', 'es2018.promise', 'es2018.regexp', 'esnext.array', 'esnext.symbol', 'esnext.intl', 'esnext.bigint', 'esnext.bigint', 'esnext.string', 'esnext.promise'.",
+                        messageText: "Argument for '--lib' option must be: 'es5', 'es6', 'es2015', 'es7', 'es2016', 'es2017', 'es2018', 'esnext', 'dom', 'dom.iterable', 'webworker', " +


It's painful when you edit something on a very very very long line.

We should convert these into baseline/snapshot tests. Not necessary for you to do in this PR, so I've filed #44950 to keep track of the issue.

Should I revert these changes?...

src/lib/esnext.string.d.ts

Co-authored-by: Anonymous <65428781+CrimsonCodes0@users.noreply.github.com>

rbuckton

Assuming there are no further web compatibility issues with .at, this looks good to me. The feature is shipping in both v8 and SpiderMonkey, so it seems fairly stable.

src/compiler/commandLineParser.ts

src/lib/esnext.array.d.ts

src/lib/esnext.string.d.ts

rbuckton · 2021-07-08T19:24:22Z

src/testRunner/unittests/config/convertCompilerOptionsFromJson.ts

@@ -295,7 +295,11 @@ namespace ts {
                        file: undefined,
                        start: 0,
                        length: 0,
-                        messageText: "Argument for '--lib' option must be: 'es5', 'es6', 'es2015', 'es7', 'es2016', 'es2017', 'es2018', 'esnext', 'dom', 'dom.iterable', 'webworker', 'webworker.importscripts', 'scripthost', 'es2015.core', 'es2015.collection', 'es2015.generator', 'es2015.iterable', 'es2015.promise', 'es2015.proxy', 'es2015.reflect', 'es2015.symbol', 'es2015.symbol.wellknown', 'es2016.array.include', 'es2017.object', 'es2017.sharedmemory', 'es2017.string', 'es2017.intl', 'es2017.typedarrays', 'es2018.asynciterable', 'es2018.intl', 'es2018.promise', 'es2018.regexp', 'esnext.array', 'esnext.symbol', 'esnext.intl', 'esnext.bigint', 'esnext.bigint', 'esnext.string', 'esnext.promise'.",
+                        messageText: "Argument for '--lib' option must be: 'es5', 'es6', 'es2015', 'es7', 'es2016', 'es2017', 'es2018', 'esnext', 'dom', 'dom.iterable', 'webworker', " +


We should convert these into baseline/snapshot tests. Not necessary for you to do in this PR, so I've filed #44950 to keep track of the issue.

rbuckton

That was supposed to be a request changes, sorry.

felipeplets

LGTM

sandersn · 2021-08-20T22:19:18Z

We discussed this in the design meeting and concluded:

at should return T | undefined, as this PR does.
The compiler should add support for negative indices on tuples, along with special support for at to work the same way. Something like

declare let t: [string, number]
let n = t.at(-1) // n: number
type TN = (typeof t)[-1] // also number?
// and perhaps even
declare let t2: [...string, number]
let n2 = t.at(-1)

Though the second example would require adding quite a bit more code to the checker.

I expect @DanielRosenwasser will link the notes when he's done preparing them.

sandersn · 2021-08-20T22:22:33Z

@rbuckton Can you take another look and merge if all your comments have been addressed?

rbuckton · 2022-02-01T01:23:12Z

It looks like a different PR was merged that already addressed this: #46291

Kingwl added 2 commits September 22, 2020 17:29

Add item method

ec5f634

fix jsdoc

b3daf96

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 22, 2020

accept baseline

b44a007

Jack-Works reviewed Sep 23, 2020

View reviewed changes

src/lib/esnext.array.d.ts Show resolved Hide resolved

sandersn requested a review from rbuckton October 5, 2020 18:44

typescript-bot assigned rbuckton Oct 5, 2020

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 5, 2020

ghost reviewed Jan 13, 2021

View reviewed changes

src/lib/esnext.array.d.ts Show resolved Hide resolved

Kingwl added 2 commits June 9, 2021 11:45

Merge branch 'master' into item_method_new

f5878f1

Rename item method

93ee38f

Kingwl added 2 commits June 9, 2021 12:07

Add bigint64 array

76e5e03

Add whitespace

aadb17d

Kingwl commented Jun 9, 2021

View reviewed changes

Kingwl changed the title ~~Add item method~~ Add at method Jun 9, 2021

ghost reviewed Jun 9, 2021

View reviewed changes

src/lib/esnext.string.d.ts Outdated Show resolved Hide resolved

Kingwl and others added 2 commits June 9, 2021 14:07

Update src/lib/esnext.string.d.ts

33df981

Co-authored-by: Anonymous <65428781+CrimsonCodes0@users.noreply.github.com>

Avoid whitespace

7ee9c40

rbuckton approved these changes Jul 8, 2021

View reviewed changes

rbuckton requested changes Jul 8, 2021

View reviewed changes

Kingwl added 2 commits July 9, 2021 14:06

Merge branch 'main' into item_method_new

25d33e5

Fix lib reference

0e27ccb

felipeplets approved these changes Jul 17, 2021

View reviewed changes

lucacasonato mentioned this pull request Jul 18, 2021

Array.at and friends not available for typechecking denoland/deno#11441

Closed

sandersn approved these changes Aug 20, 2021

View reviewed changes

rbuckton closed this Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add at method #40697

Add at method #40697

Kingwl commented Sep 22, 2020

Kingwl commented Nov 12, 2020

Jack-Works commented Nov 12, 2020

Kingwl commented Nov 12, 2020

rbuckton commented Jan 13, 2021

typescript-bot commented Jun 9, 2021

Kingwl Jun 9, 2021

rbuckton Jul 8, 2021

Kingwl Jul 9, 2021

rbuckton left a comment

rbuckton Jul 8, 2021

rbuckton left a comment

felipeplets left a comment

sandersn commented Aug 20, 2021 •

edited

Loading

sandersn commented Aug 20, 2021

rbuckton commented Feb 1, 2022

Add at method #40697

Add at method #40697

Conversation

Kingwl commented Sep 22, 2020

Kingwl commented Nov 12, 2020

Jack-Works commented Nov 12, 2020

Kingwl commented Nov 12, 2020

rbuckton commented Jan 13, 2021

typescript-bot commented Jun 9, 2021

Kingwl Jun 9, 2021

Choose a reason for hiding this comment

rbuckton Jul 8, 2021

Choose a reason for hiding this comment

Kingwl Jul 9, 2021

Choose a reason for hiding this comment

rbuckton left a comment

Choose a reason for hiding this comment

rbuckton Jul 8, 2021

Choose a reason for hiding this comment

rbuckton left a comment

Choose a reason for hiding this comment

felipeplets left a comment

Choose a reason for hiding this comment

sandersn commented Aug 20, 2021 • edited Loading

sandersn commented Aug 20, 2021

rbuckton commented Feb 1, 2022

sandersn commented Aug 20, 2021 •

edited

Loading