Fix/create element new jsx transform #41151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Andarist
commented
Oct 17, 2020
| @@ -64,7 +64,7 @@ namespace ts { | |||
| ); | |||
| } | |||
|
|
|||
| export function createExpressionForJsxElement(factory: NodeFactory, jsxFactoryEntity: EntityName | undefined, reactNamespace: string, tagName: Expression, props: Expression | undefined, children: readonly Expression[] | undefined, parentElement: JsxOpeningLikeElement, location: TextRange): LeftHandSideExpression { | |||
| export function createExpressionForJsxElement(factory: NodeFactory, callee: Expression, tagName: Expression, props: Expression | undefined, children: readonly Expression[] | undefined, location: TextRange): LeftHandSideExpression { | |||
There was a problem hiding this comment.
the signature differs now from the accompanying createExpressionForJsxFragment but this is just a util file so I don't think it's particularly important but let me know if you'd like this to be refactored somehow.
Andarist
commented
Oct 17, 2020
| @@ -40,17 +40,25 @@ namespace ts { | |||
| } | |||
|
|
|||
| function getImplicitImportForName(name: string) { | |||
| const existing = currentFileState.utilizedImplicitRuntimeImports?.get(name); | |||
| const importSource = name === "createElement" | |||
There was a problem hiding this comment.
this is a special case for the createElement within this "generic" util, but in the name of KISS I think it's perfectly OK here. The transform is tied to the semantics defined by React anyhow, this won't change often and there is near-zero chance that createElement will get reintroduced in the future in some other entrypoint in JSX runtimes
weswigham
approved these changes
Oct 19, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify that:
Backlogmilestone (required)masterbranchgulp runtestslocallyFixes #41146
cc @gaearon @lunaruan @weswigham
I've first added a commit with tests covering the cases around
keyprops and the new JSX transform as those were not covered by any tests I could find (no tests for this were introduced in #39199) and then I've implemented a fix that auto-inserts import forcreateElementfrom thejsxImportSourceitself so it should be nicely visible what actual change this PR brings.